Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable filtering for log4j properties #55

Merged
merged 1 commit into from
Oct 7, 2014
Merged

Disable filtering for log4j properties #55

merged 1 commit into from
Oct 7, 2014

Conversation

GerardPaligot
Copy link
Contributor

Change pom.xml to include log4j.properties in resources not filtered and add path to temp directory for logs of Spoon.

This PR may fix issue #12 to push on Maven.

@pschichtel
Copy link
Contributor

#12 is actually not about logging, so this commit doesn't fix #12. You should create a separate issue or don't reference an issue at all.

anyway, +1 from my side

@GerardPaligot
Copy link
Contributor Author

Well, it doesn't seem to be good. When I launch a mvn clean install and I check the log4j.properties file in spoon-core-2.3.1-SNAPSHOT-jar-with-dependencies jar, I can see my personal path for the location of the logging directory.

I don't understand why but I'm working on it.

@swolf91
Copy link
Contributor

swolf91 commented Oct 7, 2014

@GerardPaligot how about that?

    <resources>
      <resource>
        <directory>src/main/resources</directory>
        <filtering>true</filtering>
        <excludes>
          <exclude>log4j.properties</exclude>
        </excludes>
      </resource>
      <resource>
          <directory>src/main/resources</directory>
          <filtering>false</filtering>
          <includes>
              <include>log4j.properties</include>
          </includes>
      </resource>
    </resources>

you activate filtering for all files of the resource folder and exclude the log4j.properties file
and with another entry you add the log4j.properties file to your resources but without filtering.

EDIT: I tested it locally. It works for me. The spoon-log.file is in the right path.
But you definitely should edit the commit and issue message. It doesn't fix issue #12 because you don't do a central release with that fix. you just fix the logging problem 😄

@GerardPaligot
Copy link
Contributor Author

Yes, @boeserwolf91. My mistake was I indicated the full path to log4j.properties file (src/main/resources/log4j.properties).

Thanks to you!

So I change the pom.xml now, I push modifications and, when @monperrus will merge the branch, I push to Maven Central.

@swolf91
Copy link
Contributor

swolf91 commented Oct 7, 2014

@GerardPaligot Good to hear. thank you 👍

@GerardPaligot
Copy link
Contributor Author

Everything works now. I also rebase commits to remove link to issue #12.

This branch is ready to merge after the compile of Travis. :)

monperrus added a commit that referenced this pull request Oct 7, 2014
Disable filtering for log4j properties
@monperrus monperrus merged commit 1d7baea into INRIA:master Oct 7, 2014
@GerardPaligot GerardPaligot deleted the fix_12 branch October 8, 2014 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants