Support java 7 #98
Merged
Support java 7 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates CtTryWithResource/Impl to represent a try-with-resource and adds posibility to visit it. Improves tests to use the new interface CtTryWithResource when it used the old one, CtTry.
Creates MultiTypedElement interface and extended by CtLocalVariable to add the possibility to have multi types for a local variable. For example, it is used in multi catch in Java 7: there is one variable and several types.
|
This PR is now finished. It supports all java 7 concepts (see below) and all tests run. Java 7 concepts:
This PR is now ready to be merged. |
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| package spoon.reflect.code; | |||
|
|
|||
| import spoon.reflect.declaration.CtMultiTypedElement; | |||
There was a problem hiding this comment.
Could you remove this import ?
Creates a new concept in the model, CtCatchVariable. This interface defines an exception variable in a catch and can be visitable. Now, CtCatch are returning a CtCatchVariable with getParameter and not CtLocalVariable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all my contributions about the support of java 7 (for now, only test cases because spoon supports a lot of things about this version of java).
Some questions must to be discuss in the community. These questions are explained in these issues: #96 and #97.