Template matcher improvements #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why we should hide this exception and let it continue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am learning how TemplateMatcher works. I suggest some little code improvements.
There is a bug fix too, int this PR, in
isParameterSourcemethod, which returned before true, in some cases, even whenref.getDeclaration()was null. It might be OK in this method, but it would fail immediately on NullPointerException inParameters.getParameterName()onf.getDeclaration().getAnnotation(...)' so I think the change in theisParameterSource` expression is correct.I replaced
Launcher.LOGGER.error(...)by throwing of exception. I guess that spoon should visibly fail if client wants to use a template, but something bad happens. The writing to log is not enough in such case. But here I am not sure, so if you do not agree, then I gladly rollback this change.