Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-defined WFS - check on optional element wfs:boundedBy #214

Closed
danieluct opened this issue Feb 12, 2020 · 9 comments
Closed

Pre-defined WFS - check on optional element wfs:boundedBy #214

danieluct opened this issue Feb 12, 2020 · 9 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@danieluct
Copy link

When testing pre-defined WFS, a check is made against the bounding box of the returned feature collection (/wfs:FeatureCollection/wfs:boundedBy/gml:Envelope/@srsName) : https://github.com/inspire-eu-validation/ets-repository/blob/cf007c52279f874324e9e554ab19b19651cd8112/service/ds-wfs-pre-defined-soapui-project.xml#L5266

The wfs:boundedBy element is however optional according to the WFS 2.0 standard and I am not aware of any requirement to provide it in INSPIRE technical documents

@danielnavarrogeo
Copy link
Contributor

Dear @danieluct

Could you provide us the url of the service that you are validating in order to analyze the issue?

Regards

@danieluct
Copy link
Author

@iuriemaxim
Copy link

iuriemaxim commented Jun 19, 2020

@carlospzurita Please remove the test of the bounding box for Predefined WFS as the wfs:boundedBy element is optional according to the WFS 2.0 standard and there are any requirement to provide it in INSPIRE technical documents.

This is not possible to be delivered in Geoserver, and in case that we will write code to deliver the bounding box, it takes a huge time to be computed depending on the WFS elements that are requested (filtered).

I assume that is easy to remove a test in the validator and this issue is pending from to much time, so it could be done for this release in June, not to wait until December again.

We are waiting for two issues to be solved in order to have a reference implementation that would pass all the tests. This is one of it and another one is related to a CITE test (spatial Join issue)

Iurie

@carlospzurita
Copy link
Contributor

Dears @iuriemaxim @danieluct

We have been discussing the approach and we decided that indeed the boundedBy element is optional for the responses of the storedQuery. What we are going to implement a is an optional check for the CRS in case of the existence of the element boundedBy, but else it will pass directly.

@iuriemaxim
Copy link

@carlospzurita Thank you for the good news!

@iuriemaxim
Copy link

iuriemaxim commented Jul 31, 2020

@carlospzurita There are any new information regarding this issue? Most probably the fix should not be so difficult.

@carlospzurita
Copy link
Contributor

A fix for this issue has been published on the staging instance. Please let us know if everything is in order.

@carlospzurita carlospzurita added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Aug 14, 2020
@iuriemaxim
Copy link

@carlospzurita Thank you for the fix.

The following service was tested and no errors were trigerred anymore:
https://inspire.meteoromania.ro/WIGOS/WFS?request=GetCapabilities&service=WFS&version=2.0.0

Still one issue to go (#209) and WFS tests are ok. Probably just certain relaxed tests need to be further checked and some topics to be clarified.

The issue can be marked as solved in order to be deployed into production.

@iuriemaxim
Copy link

@carlospzurita Thank you for the fix.

The following service was tested and no errors were trigerred anymore:
https://inspire.meteoromania.ro/WIGOS/WFS?request=GetCapabilities&service=WFS&version=2.0.0

Still one issue to go (#209) and WFS tests are ok. Probably just certain relaxed tests need to be further checked and some topics to be clarified.

@carlospzurita carlospzurita added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Aug 17, 2020
@carlospzurita carlospzurita added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

6 participants