Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea Regions - SeaBedArea fails geometry constraint test #830

Closed
robblis opened this issue Aug 22, 2022 · 5 comments
Closed

Sea Regions - SeaBedArea fails geometry constraint test #830

robblis opened this issue Aug 22, 2022 · 5 comments
Assignees
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Milestone

Comments

@robblis
Copy link

robblis commented Aug 22, 2022

Hi Validator Team,

We are working on validating our Sea Regions theme.

When testing the SeaBedArea feature type we see the following failures for the Conformance Class 'Application schema, Sea Regions' > constraints > geometry test...

XML document 'service.xml', SeaBedArea 'srSeaBedAreaS.6001': The constraint 'the geometry element is represented as either a surface or a point' is violated.
XML document 'service.xml', SeaBedArea 'srSeaBedAreaS.6002': The constraint 'the geometry element is represented as either a surface or a point' is violated.

We are returning the following XML regarding the geometry...

sr:geometry
<gml:Polygon gml:id="srSeaBedAreaS.ifcid.6001.Shape.Geom_0" srsName="http://www.opengis.net/def/crs/EPSG/0/4258" srsDimension="2">
gml:exterior
gml:LinearRing
gml:posList-14.323404255000 56.872340426000 -26.119148936000 90.995744681000 -54.344680851000 102.370212766000 -64.034042553000 104.897872340000 -96.472340426000 77.093617021000 -101.106382979000 55.608510638000 -99.421276596000 9.689361702000 -99.421276596000 -18.114893617000 -85.097872340000 -42.127659574000 -60.242553191000 -47.182978723000 -30.753191489000 -28.646808511000 -15.165957447000 16.429787234000 -14.323404255000 56.872340426000</gml:posList>
</gml:LinearRing>
</gml:exterior>
</gml:Polygon>
</sr:geometry>

We believe that the gml:Polygon is a valid surface type. Please see #458 for a similar issue and resolution. I've attached the service returned XML file.

We see the same constraint error for the SeaSurfaceArea feature type as well.

Please advise.

Thanks,
Robert
SR_SeaBedArea_Service.zip

@fabiovinci
Copy link
Collaborator

Dear @robblis,

since a similar issue has been already discussed and solved, we will apply the same change also for the SR data theme.

@fabiovinci fabiovinci self-assigned this Aug 26, 2022
@fabiovinci fabiovinci added this to In progress in Validator issues Aug 26, 2022
fabiovinci added a commit to inspire-eu-validation/data-sr that referenced this issue Aug 29, 2022
Update of the admitted geometries according to the issue: INSPIRE-MIF/helpdesk-validator#830
@fabiovinci
Copy link
Collaborator

The related ATS has been modified.

@dperezBM, @arantzaetxebarria, could you please update the related ETS? Thanks

@dperezBM
Copy link
Collaborator

Dear @robblis
The solution is in staging environment. Could you verify that the validation is now correct?
Regards

PS: @fabiovinci could you also check it?

@dperezBM dperezBM added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing non-breaking change The change makes tests less restrictive and it has no impact on resources already tested and removed under development labels Sep 20, 2022
@fabiovinci
Copy link
Collaborator

The fix is ok for me.
It can be included in the next release.

@fabiovinci fabiovinci added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Sep 20, 2022
@robblis
Copy link
Author

robblis commented Sep 20, 2022

Hi @dperezBM ,

We've re-tested on staging and the tests pass for SeaBedArea and SeaSurfaceArea.

Thanks for the update.

Robert

@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Sep 22, 2022
@project-bot project-bot bot moved this from In progress to Production: latest release in Validator issues Sep 22, 2022
@fabiovinci fabiovinci removed this from Production: latest release in Validator issues Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Projects
None yet
Development

No branches or pull requests

4 participants