Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY Theme - hy-n:HydroNode The node is not located at the start or end of any link feature in the data set. #852

Closed
robblis opened this issue Sep 23, 2022 · 5 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@robblis
Copy link

robblis commented Sep 23, 2022

Hi Validator Team,

We are testing our HY theme services and are seeing the following error.

Conformance Class 'Application schema, Hydrography - Network' > Geometry > hy-n-as.b.1: No free hydrographic nodes

The dataset has 1 feature(s) with errors for this assertion.
XML document 'service.xml', HydroNode 'netElementP.300501': The node is not located at the start or end of any link feature in the data set.

Here is the service we are using: https://inspiredemo.esri.com/arcgis/rest/services/hy_test/MapServer/exts/InspireFeatureDownload/service?REQUEST=GetFeature&VERSION=2.0.0&SERVICE=WFS&TYPENAMES=hy-n:HydroNode&COUNT=1&Namespaces=xmlns(hy-n,http%3A%2F%2Finspire.ec.europa.eu%2Fschemas%2Fhy-n%2F4.0)

We must use Resolve and ResolveDepth parameters to avoid the errors.

Can you add the fix for HY to recognize external links similar for the fix applied to the AU theme?
See the following issue for similar resolutions. #788

Thanks,
Robert

@fabiovinci
Copy link
Collaborator

Dear @robblis,

the test fails since the validator is not able to verify the geometries of the related WatercourseLink elements that are referenced in the spokeEnd and spokeStart elements.
It can only verify if the node is at the start or end of a watercourse link that is available in the same datasets.
Since you are validating single feature types (as in this case, only the HydroNode) the test doesn't work.

We are revising the related ATS and we should change the first check from automated to automated/manual, so in case WatercourseLink elements are not available in the dataset you are testing, a manual check will be required.

In any case, I would suggest validating such types of datasets using the Resolve and ResolveDepth parameters, so you are sure your dataset conforms to all requirements.

@fabiovinci fabiovinci self-assigned this Sep 27, 2022
@fabiovinci fabiovinci added this to To do in Validator issues Oct 3, 2022
fabiovinci added a commit to inspire-eu-validation/data-hy that referenced this issue Nov 21, 2022
Update automatic test introducing a manual check in case the HydroNode and the WatercourseLink feature types are not contained in the same dataset. See issue INSPIRE-MIF/helpdesk-validator#852
@fabiovinci
Copy link
Collaborator

Dear @robblis,

we updated the Geometry test in the ATS to report a message that requires manual checks if the HydroNode and the WatercourseLink feature types are not contained in the same dataset.

We will apply the fix in the ETS and let you know when it will be available in staging for testing.

@dperezBM
Copy link
Collaborator

dperezBM commented Dec 2, 2022

Dear @robblis

The fix for this issue is available in staging environment. Could you verify it?

Regards

@dperezBM dperezBM assigned robblis and unassigned dperezBM Dec 2, 2022
@dperezBM dperezBM added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Dec 2, 2022
@fabiovinci
Copy link
Collaborator

Dear all,
I tested the solution in staging and it works fine.

@fabiovinci fabiovinci removed their assignment Dec 2, 2022
@fabiovinci fabiovinci moved this from In progress to Staging: for acceptance in Validator issues Dec 2, 2022
@robblis
Copy link
Author

robblis commented Dec 2, 2022

Hi @fabiovinci ,

I've ran a new test and no validation errors occurred.

Thanks for the fix.

Robert

@arantzaetxebarria arantzaetxebarria added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Dec 5, 2022
@arantzaetxebarria arantzaetxebarria added this to the v2023.0 milestone Dec 5, 2022
@fabiovinci fabiovinci moved this from Staging: for acceptance to Staging: in release planning in Validator issues Dec 5, 2022
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jan 25, 2023
@fabiovinci fabiovinci moved this from Staging: in release planning to Production: latest release in Validator issues Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
Validator issues
  
Production: latest release
Development

No branches or pull requests

4 participants