Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata dataset: Resource Locator / Add some context so that end user knows what the test is looking at. #94

Closed
fxprunayre opened this issue Jul 31, 2019 · 5 comments
Labels
deployed in reference validator Solution deployed in production

Comments

@fxprunayre
Copy link

When checking URL, the validator reports:

XML document 'file.xml', record 'f6aa98bd-9785-4583-b334-1fabeb7f61a5': 
The provided Resource Locator URL is not working.

but if you have 30 urls in the record, end user don't know which one is wrong.

Advertise it in the error message
inspire-eu-validation/ets-repository@0e9151e

After the changes, error is:

XML document 'file.xml', record 'c651bc41-d5da-49de-ba47-c51eabbb2007': The provided Resource Locator URL
 '/local/tr/geography/eea_ref_grids/eea_v_3035_100_km_eea-ref-grid-tr_2011/tr_100km.shp'
 is not working.

Relates to inspire-eu-validation/ets-repository#315

@michellutz
Copy link

The proposed change looks good to me.

@josemasensio
Copy link
Contributor

josemasensio commented Aug 8, 2019

Dear @fxprunayre,

Could you please cancel the pull request against master and create one request per issue/modification against staying branch?
Once each request is merged, we will test it to check that everything is correct and come back to you so you can also test that your changes are correct.

We appreciate your collaboration. Is good to see that the community is interested on improving this tool.

Greetings.

@fxprunayre
Copy link
Author

Could you please cancel the pull request against master

Sure.

and create one request per issue/modification against staying branch?

I think you can easily cherry-pick the relevant commits or copy/paste the couple of lines affected by the changes. HTH.

@josemasensio
Copy link
Contributor

Dear @fxprunayre,

Thank you for closing the issue. We will implement the issue. We will let you know when they are implemented.

Best regards.

@josemasensio
Copy link
Contributor

Dear @fxprunayre,

The solution you proposed is deployed on staging instance. We will apreciate if you can give us your feedback.

Best regards.

@josemasensio josemasensio added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Aug 30, 2019
@josemasensio josemasensio added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Sep 17, 2019
@josemasensio josemasensio added this to the 2019.10 milestone Oct 28, 2019
@josemasensio josemasensio added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

5 participants