Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOW] Add components marked with "Exclude from bill of materials" to position output dnf_filter #429

Closed
Swij opened this issue May 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request question This is just a question, not a problem

Comments

@Swij
Copy link

Swij commented May 4, 2023

What do you want to achieve?
Components that are marked with "Exclude from bill of materials" in the schematic should not be included in the type: position output.

I have added the option dnf_filter: _kibom_dnf, but this filter only removes components with "dnf" in the _kibom_dnf_FIELD.

Is there a filter for components with the "Exclude from bill of materials" marking?

Do you have some PCB/Schematic to use as example?
Just add a resistor to the schematic and check the "Exclude from bill of materials" box in its properties.

Do you have some configuration file (.kibot.yaml) that you are using?

  - name: 'position_example'
    type: 'position'
    options:
      dnf_filter: _kibom_dnf

Environment (please complete the following information):
I'm running KiBot both locally (Debian) and in a CI/CD workflow on GitLab and GitHub. All use the kicad7_auto_full:latest docker image.

@Swij Swij added the question This is just a question, not a problem label May 4, 2023
@set-soft set-soft added bug Something isn't working enhancement New feature or request labels May 4, 2023
@set-soft
Copy link
Member

set-soft commented May 4, 2023

Hi @Swij !
Currently we don't have such an option. I think it could be implemented.
Note that you are using the wrong flag, in order to exclude components from the position file you must use the PCBNew option that explicitly asks to remove them. Which now I found doesn't work correctly when only SMD components are selected.

set-soft added a commit that referenced this issue May 4, 2023
- When only SMD components are selected.

See #429
set-soft added a commit that referenced this issue May 5, 2023
- `exclude_not_in_bom` and `exclude_not_on_board` to use KiCad 6+ flags

Closes #429
@set-soft
Copy link
Member

set-soft commented May 5, 2023

Hi @Swij !

The above patches fixes the above mentioned problem with Exclude from position files and adds two new options to the generic filter to filter using the Exclude from bill of materials and Exclude from board flags.

Please check if you can use them.

@set-soft set-soft closed this as completed May 5, 2023
@Swij
Copy link
Author

Swij commented May 5, 2023

Wow, thanks! That was quick :)

Looks like it's working now with the dev image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question This is just a question, not a problem
Projects
None yet
Development

No branches or pull requests

2 participants