Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Symbol Unit Custom Names #513

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Handle Symbol Unit Custom Names #513

merged 1 commit into from
Nov 6, 2023

Conversation

Andrew-Collins
Copy link

Hi @set-soft,

Firstly, thank you for all your hard work on kibot and associated tools.

The intention of this pull request is to add handling of custom unit names, as described in:
https://docs.kicad.org/7.0/en/eeschema/eeschema.html#creating-and-editing-symbols
(can't link to the exact subsection, search for 'Set Unit Display Name')

Kibot (v1.6.3) gives the following error if a symbol with a custom unit name is used:
ERROR:Unknown symbol attribute `[Symbol('unit_name'), '<UNIT NAME>']` (kibot.gs - gs.py:731)

The sexpr formatting isn't described in: https://dev-docs.kicad.org/en/file-formats/sexpr-schematic/
But is pretty basic: (unit_name "<UNIT NAME>")

I have added handling of this field, and stored it in the LibComponent object.

A minimum reproducable project can be found here:
https://github.com/Andrew-Collins/unit_name_mrp.git

@set-soft set-soft merged commit 8bc7ea6 into INTI-CMNB:master Nov 6, 2023
@set-soft
Copy link
Member

set-soft commented Nov 6, 2023

Thanks for the patch @Andrew-Collins !
Note that I also added the code to store the attribute when creating a variant of the schematic. Also note that the changes are in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants