Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @set-soft,
Firstly, thank you for all your hard work on kibot and associated tools.
The intention of this pull request is to add handling of custom unit names, as described in:
https://docs.kicad.org/7.0/en/eeschema/eeschema.html#creating-and-editing-symbols
(can't link to the exact subsection, search for 'Set Unit Display Name')
Kibot (v1.6.3) gives the following error if a symbol with a custom unit name is used:
ERROR:Unknown symbol attribute `[Symbol('unit_name'), '<UNIT NAME>']` (kibot.gs - gs.py:731)
The sexpr formatting isn't described in: https://dev-docs.kicad.org/en/file-formats/sexpr-schematic/
But is pretty basic:
(unit_name "<UNIT NAME>")
I have added handling of this field, and stored it in the LibComponent object.
A minimum reproducable project can be found here:
https://github.com/Andrew-Collins/unit_name_mrp.git