Unit test and documentation #20
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,27 @@ | ||
| import * as React from 'react'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import Dashboard from 'route/dashboard/Dashboard'; | ||
|
|
||
| jest.mock('route/history/Chart', () => ({ | ||
| default: () => <div>chart-mock</div>, | ||
| })); | ||
| jest.mock('route/history/RecentRuns', () => ({ | ||
| default: () => <div>recent-runs-mock</div>, | ||
| })); | ||
|
|
||
| describe('Dashboard', () => { | ||
| beforeEach(() => { | ||
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it('renders Dashboard', () => { | ||
| render(<Dashboard />); | ||
| expect(true); | ||
| }); | ||
|
|
||
| it('renders Chart and RecentRuns components', () => { | ||
| render(<Dashboard />); | ||
| expect(screen.queryByText('chart-mock')).toBeInTheDocument(); | ||
| expect(screen.queryByText('recent-runs-mock')).toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,19 @@ | ||
| import * as React from 'react'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import DigitalTwins from '../src/route/digitaltwins/DigitalTwins'; | ||
|
|
||
| jest.mock('route/digitaltwins/Workflows', () => ({ | ||
| default: () => <div>workflows-mock</div>, | ||
| })); | ||
|
|
||
| describe('Digital Twins', () => { | ||
| it('reder DigitalTwin', () => { | ||
| render(<DigitalTwins />); | ||
| expect(true); | ||
| }); | ||
|
|
||
| it('renders Dashboard woth components', () => { | ||
| render(<DigitalTwins />); | ||
| expect(screen.queryByText('workflows-mock')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,34 @@ | ||
| import * as React from 'react'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import Iframe from '../src/components/Iframe'; | ||
|
|
||
| describe('Iframe', () => { | ||
| var iframe: HTMLIFrameElement; | ||
|
|
||
| beforeEach(() => { | ||
| render(<Iframe url="https://example.com/" title="Example" />); | ||
| iframe = screen.getByTitle('Example') as HTMLIFrameElement; | ||
| }); | ||
|
|
||
| it('renders an iframe element with the correct src and title', () => { | ||
|
There was a problem hiding this comment. Similar blocks of code found in 2 locations. Consider refactoring. |
||
| expect(iframe.src).toBe('https://example.com/'); | ||
| }); | ||
|
|
||
| it('sets the iframe width to 100%', () => { | ||
|
There was a problem hiding this comment. Similar blocks of code found in 2 locations. Consider refactoring. |
||
| expect(iframe.width).toBe('100%'); | ||
| }); | ||
|
|
||
| it('sets the iframe height to 100% if fullsize prop is not provided', () => { | ||
| expect(iframe.style.height).toBe('100%'); | ||
| expect(iframe.style.flexGrow).toBe(''); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Iframe fullsize', () => { | ||
| it('sets the iframe height to auto if fullsize prop is provided', () => { | ||
| render(<Iframe url="https://example.com/" title="Example" fullsize />); | ||
| const iframe = screen.getByTitle('Example') as HTMLIFrameElement; | ||
| expect(iframe.style.flexGrow).toBe('1'); | ||
| expect(iframe.style.height).toBe(''); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadtalasila So codeclimate is kind of dumb when it comes to test... Is it okay if we exclude test from codeclimate or how do we prevent this redunt code smell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SyntaxXeror
Please check codeclimate config docs. If I am not mistaken, there must be a way to skip this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadtalasila you already replyed to this early where you wrote directly from email, so this is fixed :)