Fix: aiori->delete is now aiori->remove #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With commit [bfc922f225](hpc/ior@bfc922f) the aiori interface changes `delete` to `remove`. This commit adapts the IO500 code to this change.
blastmaster
requested review from
adilger,
gflofst,
gmarkomanolis,
seattleplus and
JulianKunkel
as code owners
gmarkomanolis
approved these changes
Apr 3, 2024
JulianKunkel
approved these changes
Apr 3, 2024
|
We need to update the hash code for this change
…________________________________
From: Julian Kunkel ***@***.***>
Sent: Wednesday, April 3, 2024 4:55:37 AM
To: IO500/io500 ***@***.***>
Cc: Lofstead, Jay F ***@***.***>; Review requested ***@***.***>
Subject: [EXTERNAL] Re: [IO500/io500] Fix: aiori->delete is now aiori->remove (PR #65)
@JulianKunkel approved this pull request.
—
Reply to this email directly, view it on GitHub<#65 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAUR4WXH3MLTHKTALN7H5ZLY3PN2TAVCNFSM6AAAAABFUZTJ36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZWGM4DAMZVGI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
adilger
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit bfc922f225 the aiori interface changes
deletetoremove. This commit adapts the IO500 code to this change.