Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Add Visual Studio 2017 compatibility. Fixes #17 #18

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

jschneid
Copy link
Contributor

@jschneid jschneid commented Mar 28, 2017

  • Change target framework to 4.6 (from 4.5.2) to fix an error about
    reference compatibility (http://stackoverflow.com/a/34299520/12484)
  • Change Visual Studio version from 14 (VS2015) to 15 (VS2017)
  • Increment extension version to 15.2 (from 15.1)

- Change target framework to 4.6 (from 4.5.2) to fix an error about
reference compatibility (http://stackoverflow.com/a/34299520/12484)
- Change Visual Studio version from 14 (VS2015) to 15 (VS2017)
- Increment version to 15.2 (from 15.1)
@@ -31,4 +31,7 @@ For more information please visit https://github.com/IPWright83/VSFileNav
<Assets>
<Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" />
</Assets>
<Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0.26208.0,16.0)" DisplayName="Visual Studio core editor" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschneid
Copy link
Contributor Author

jschneid commented Mar 28, 2017

I tested installing the newly-built VSNav.vsix from this branch on my local Visual Studio 2017, and it seemed to work great!

I didn't try installing the new .vsix on any older Visual Studio versions, though.

@IPWright83
Copy link
Owner

@jschneid thanks very much. I'll do some quick testing of it over the rest of this week. If all's good I'll merge in the PR :)

@zack-snyder
Copy link

What is the current state here? Is it VS 2017 read?

@jschneid
Copy link
Contributor Author

jschneid commented Jun 1, 2017

FWIW, I've been using the build from this PR since March with my local copy of VS 2017 with no issues!

@IPWright83 IPWright83 merged commit 408367f into IPWright83:master Jun 1, 2017
@ghost
Copy link

ghost commented Nov 26, 2017

@IPWright83, @jschneid:
This is not working for me. It seems it still installs version 15.1 instead of 15.2, that might be the problem.

Also, it'd be nice to have the new version uploaded to the Visual Studio Marketplace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants