python3 installer #167
Merged
python3 installer #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Apr 23, 2020
tasks/dataverse-install.yml
Outdated
| - name: copy jhove configs | ||
| shell: "cp /tmp/dvinstall/jhove* {{ glassfish_dir }}/glassfish/domains/{{ dataverse.glassfish.domain }}/config" | ||
|
|
||
| # python3 installer still calls glassfish-setup.sh |
There was a problem hiding this comment.
Suggested change
| # python3 installer still calls glassfish-setup.sh | |
| # python3 installer still calls as-setup.sh |
There was a problem hiding this comment.
i had been meaning to fix that.
|
|
||
| [database] | ||
| POSTGRES_ONLY = false | ||
| POSTGRES_SERVER = {{ db.postgres.host }} |
There was a problem hiding this comment.
Suggested change
| POSTGRES_SERVER = {{ db.postgres.host }} | |
| POSTGRES_SERVER = {{ db.postgres.host }} |
templates/interactive.config.j2
Outdated
| GLASSFISH_DIRECTORY = | ||
| ADMIN_EMAIL = :\n(please enter a valid email address!) | ||
| MAIL_SERVER = | ||
| POSTGRES_SERVER = |
There was a problem hiding this comment.
I don't really understand what it means when there's no value? I assume it'll just use the default (localhost in this case, probably).
There was a problem hiding this comment.
hmmm. i think this was a partial template that got included by mistake. i'll remove it.
pallinger
pushed a commit
to dsd-sztaki-hu/dataverse-ansible-deprecated
that referenced
this pull request
Jan 28, 2022
Set the owner of the branding files to dataverse (instead of root)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #139