Feat: Add pagination total results #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
pm.GREI-d-2.7.1
g-saracca
requested changes
Apr 25, 2024
tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx
Outdated
Show resolved
Hide resolved
g-saracca
reviewed
Apr 29, 2024
tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx
Outdated
Show resolved
Hide resolved
g-saracca
approved these changes
Apr 29, 2024
GPortas
approved these changes
May 2, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
Feat: Add pagination total results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Formats the total number of items of the pagination result according to the user's preferred language. Applied to locales/en/pagination
Which issue(s) this PR closes:
Closes #330
Special notes for your reviewer:
Suggestions on how to test this:
Storybook (There are additional areas that can be viewed too)
Sample URL 1: http://localhost:6006/?path=/story/sections-dataset-page-datasetfiles--no-filters
Cypress
Relating tests found in PaginationResultsInfo.spec.tsx
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
See Issue #330
Is there a release notes update needed for this change?:
Additional documentation: