Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with license backward incompatibility #33

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Aug 11, 2022

What this PR does / why we need it:

Due to backward incompatible changes introduced in Dataverse 5.10, we can no longer load up our sample data datasets.

This pull request changes the "license" field in each dataset JSON file in two ways.

  • "CC0" has been changed to "CC 1.0"
  • "NONE" has been removed (the whole line: "license":"NONE",)

Which issue(s) this PR closes:

Special notes for your reviewer:

Please don't mind the huge diff for the datasetno dataset. The JSON was on a single line and I reformatted it with jq before fixing the "license" field. That dataset can't be published anyway. I opened #32 for that.

While the changes in this PR should allow all datasets to be created, I don't think the combination of license, termsOfUse, and termsOfAccess makes sense for a lot of these datasets. To keep this issue/PR "trivial" in size, I opened a #33 to handle this separately.

Suggestions on how to test this:

Load up the sample data specified in dvconfig.py.sample (copy this to dvconfig.py per the README).

In addition, you could enable the sample data feature in dataverse-ansible. You'd want to point to the branch for this PR like this:

  sampledata:
    enabled: false
    dir: /tmp/sampledata
    repo: https://github.com/IQSS/dataverse-sample-data.git
    branch: 30-license-backward-incompatibility
    venv: /tmp/sampledata/venv

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

We might want to make these incompatibility more clear in the 5.10 release notes: https://github.com/IQSS/dataverse/releases/tag/v5.10

Additional documentation:

None.

Replace "CC0" with "CC0 1.0".

Remove `"license": "NONE"` entirely as it's no longer supported.
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I took a look at the files and it looks like you got them all.

@sekmiller sekmiller removed their assignment Aug 29, 2022
@sekmiller sekmiller self-assigned this Sep 7, 2022
@sekmiller sekmiller merged commit 42fdb92 into master Sep 7, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Sep 7, 2022
@sekmiller sekmiller deleted the 30-license-backward-incompatibility branch September 7, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

sample datasets cannot be created in Dataverse 5.10+ due to backward incompatibility with regard to licenses
2 participants