deal with license backward incompatibility #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to backward incompatible changes introduced in Dataverse 5.10, we can no longer load up our sample data datasets.
This pull request changes the "license" field in each dataset JSON file in two ways.
"license":"NONE",
)Which issue(s) this PR closes:
Special notes for your reviewer:
Please don't mind the huge diff for the datasetno dataset. The JSON was on a single line and I reformatted it with jq before fixing the "license" field. That dataset can't be published anyway. I opened #32 for that.
While the changes in this PR should allow all datasets to be created, I don't think the combination of license, termsOfUse, and termsOfAccess makes sense for a lot of these datasets. To keep this issue/PR "trivial" in size, I opened a #33 to handle this separately.
Suggestions on how to test this:
Load up the sample data specified in dvconfig.py.sample (copy this to dvconfig.py per the README).
In addition, you could enable the sample data feature in dataverse-ansible. You'd want to point to the branch for this PR like this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
We might want to make these incompatibility more clear in the 5.10 release notes: https://github.com/IQSS/dataverse/releases/tag/v5.10
Additional documentation:
None.