Merge pull request #9971 from IQSS/revert-9783-9714-files-api-extensi…

…on-filters Revert "Dataset files API extension for filters"
IQSS · Oct 4, 2023 · 7e0738e · 7e0738e
2 parents e861c41 + 122565a
commit 7e0738e
Show file tree

Hide file tree

Showing 20 changed files with 174 additions and 1,110 deletions.
diff --git a/doc/release-notes/9714-files-api-extension-filters.md b/doc/release-notes/9714-files-api-extension-filters.md
diff --git a/doc/release-notes/9785-files-api-extension-search-text.md b/doc/release-notes/9785-files-api-extension-search-text.md
diff --git a/doc/release-notes/9834-files-api-extension-counts.md b/doc/release-notes/9834-files-api-extension-counts.md
diff --git a/doc/release-notes/9851-datafile-payload-extension-new-file-access-endpoints.md b/doc/release-notes/9851-datafile-payload-extension-new-file-access-endpoints.md
diff --git a/doc/sphinx-guides/source/api/dataaccess.rst b/doc/sphinx-guides/source/api/dataaccess.rst
@@ -404,18 +404,6 @@ A curl example using an ``id``::
 
     curl -H "X-Dataverse-key:$API_TOKEN" -X GET http://$SERVER/api/access/datafile/{id}/listRequests
 
-User Has Requested Access to a File:
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-``/api/access/datafile/{id}/userFileAccessRequested``
-
-This method returns true or false depending on whether or not the calling user has requested access to a particular file.
-
-A curl example using an ``id``::
-
-    curl -H "X-Dataverse-key:$API_TOKEN" -X GET "http://$SERVER/api/access/datafile/{id}/userFileAccessRequested"
-
-
 Get User Permissions on a File:
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

diff --git a/doc/sphinx-guides/source/api/native-api.rst b/doc/sphinx-guides/source/api/native-api.rst
@@ -970,45 +970,6 @@ This endpoint supports optional pagination, through the ``limit`` and ``offset``
 
   curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?limit=10&offset=20"
 
-Category name filtering is also optionally supported. To return files to which the requested category has been added.
-
-Usage example:
-
-.. code-block:: bash
-
-  curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?categoryName=Data"
-
-Content type filtering is also optionally supported. To return files matching the requested content type.
-
-Usage example:
-
-.. code-block:: bash
-
-  curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?contentType=image/png"
-
-Filtering by search text is also optionally supported. The search will be applied to the labels and descriptions of the dataset files, to return the files that contain the text searched in one of such fields.
-
-Usage example:
-
-.. code-block:: bash
-
-  curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?searchText=word"
-
-File access filtering is also optionally supported. In particular, by the following possible values:
-
-* ``Public``
-* ``Restricted``
-* ``EmbargoedThenRestricted``
-* ``EmbargoedThenPublic``
-
-If no filter is specified, the files will match all of the above categories.
-
-Usage example:
-
-.. code-block:: bash
-
-  curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?accessStatus=Public"
-
 Ordering criteria for sorting the results is also optionally supported. In particular, by the following possible values:
 
 * ``NameAZ`` (Default)
@@ -1018,42 +979,14 @@ Ordering criteria for sorting the results is also optionally supported. In parti
 * ``Size``
 * ``Type``
 
+Please note that these values are case sensitive and must be correctly typed for the endpoint to recognize them.
+
 Usage example:
 
 .. code-block:: bash
 
   curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?orderCriteria=Newest"
 
-Please note that both filtering and ordering criteria values are case sensitive and must be correctly typed for the endpoint to recognize them.
-
-Keep in mind that you can combine all of the above query params depending on the results you are looking for.
-
-Get File Counts in a Dataset
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Get file counts, for the given dataset and version.
-
-The returned file counts are based on different criteria:
-
-- Total (The total file count)
-- Per content type
-- Per category name
-- Per access status (Possible values: Public, Restricted, EmbargoedThenRestricted, EmbargoedThenPublic)
-
-.. code-block:: bash
-
-  export SERVER_URL=https://demo.dataverse.org
-  export ID=24
-  export VERSION=1.0
-
-  curl "$SERVER_URL/api/datasets/$ID/versions/$VERSION/files/counts"
-
-The fully expanded example above (without environment variables) looks like this:
-
-.. code-block:: bash
-
-  curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files/counts"
-
 View Dataset Files and Folders as a Directory Index
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -2899,13 +2832,13 @@ A curl example using an ``ID``
   export SERVER_URL=https://demo.dataverse.org
   export ID=24
 
-  curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER_URL/api/files/$ID/downloadCount"
+  curl "$SERVER_URL/api/files/$ID/downloadCount"
 
 The fully expanded example above (without environment variables) looks like this:
 
 .. code-block:: bash
 
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X GET "https://demo.dataverse.org/api/files/24/downloadCount"
+  curl "https://demo.dataverse.org/api/files/24/downloadCount"
 
 A curl example using a ``PERSISTENT_ID``
 
@@ -2915,53 +2848,16 @@ A curl example using a ``PERSISTENT_ID``
   export SERVER_URL=https://demo.dataverse.org
   export PERSISTENT_ID=doi:10.5072/FK2/AAA000
 
-  curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER_URL/api/files/:persistentId/downloadCount?persistentId=$PERSISTENT_ID"
+  curl "$SERVER_URL/api/files/:persistentId/downloadCount?persistentId=$PERSISTENT_ID"
 
 The fully expanded example above (without environment variables) looks like this:
 
 .. code-block:: bash
 
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X GET "https://demo.dataverse.org/api/files/:persistentId/downloadCount?persistentId=doi:10.5072/FK2/AAA000"
+  curl "https://demo.dataverse.org/api/files/:persistentId/downloadCount?persistentId=doi:10.5072/FK2/AAA000"
 
 If you are interested in download counts for multiple files, see :doc:`/api/metrics`.
 
-File Has Been Deleted
-~~~~~~~~~~~~~~~~~~~~~
-
-Know if a particular file that existed in a previous version of the dataset no longer exists in the latest version.
-
-A curl example using an ``ID``
-
-.. code-block:: bash
-
-  export API_TOKEN=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
-  export SERVER_URL=https://demo.dataverse.org
-  export ID=24
-
-  curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER_URL/api/files/$ID/hasBeenDeleted"
-
-The fully expanded example above (without environment variables) looks like this:
-
-.. code-block:: bash
-
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X GET "https://demo.dataverse.org/api/files/24/hasBeenDeleted"
-
-A curl example using a ``PERSISTENT_ID``
-
-.. code-block:: bash
-
-  export API_TOKEN=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
-  export SERVER_URL=https://demo.dataverse.org
-  export PERSISTENT_ID=doi:10.5072/FK2/AAA000
-
-  curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER_URL/api/files/:persistentId/hasBeenDeleted?persistentId=$PERSISTENT_ID"
-
-The fully expanded example above (without environment variables) looks like this:
-
-.. code-block:: bash
-
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X GET  "https://demo.dataverse.org/api/files/:persistentId/hasBeenDeleted?persistentId=doi:10.5072/FK2/AAA000"
-
 Updating File Metadata
 ~~~~~~~~~~~~~~~~~~~~~~
 
@@ -3011,55 +2907,6 @@ Also note that dataFileTags are not versioned and changes to these will update t
 
 .. _EditingVariableMetadata:
 
-Updating File Metadata Categories
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Updates the categories for an existing file where ``ID`` is the database id of the file to update or ``PERSISTENT_ID`` is the persistent id (DOI or Handle) of the file. Requires a ``jsonString`` expressing the category names.
-
-Although updating categories can also be done with the previous endpoint, this has been created to be more practical when it is only necessary to update categories and not other metadata fields.
-
-A curl example using an ``ID``
-
-.. code-block:: bash
-
-  export API_TOKEN=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
-  export SERVER_URL=https://demo.dataverse.org
-  export ID=24
-
-  curl -H "X-Dataverse-key:$API_TOKEN" -X POST \
-    -F 'jsonData={"categories":["Category1","Category2"]}' \
-    "$SERVER_URL/api/files/$ID/metadata/categories"
-
-The fully expanded example above (without environment variables) looks like this:
-
-.. code-block:: bash
-
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X POST \
-    -F 'jsonData={"categories":["Category1","Category2"]}' \
-    "http://demo.dataverse.org/api/files/24/metadata/categories"
-
-A curl example using a ``PERSISTENT_ID``
-
-.. code-block:: bash
-
-  export API_TOKEN=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
-  export SERVER_URL=https://demo.dataverse.org
-  export PERSISTENT_ID=doi:10.5072/FK2/AAA000
-
-  curl -H "X-Dataverse-key:$API_TOKEN" -X POST \
-    -F 'jsonData={"categories":["Category1","Category2"]}' \
-    "$SERVER_URL/api/files/:persistentId/metadata/categories?persistentId=$PERSISTENT_ID"
-
-The fully expanded example above (without environment variables) looks like this:
-
-.. code-block:: bash
-
-  curl -H "X-Dataverse-key:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -X POST \
-    -F 'jsonData={"categories":["Category1","Category2"]}' \
-    "https://demo.dataverse.org/api/files/:persistentId/metadata/categories?persistentId=doi:10.5072/FK2/AAA000"
-
-Note that if the specified categories do not exist, they will be created.
-
 Editing Variable Level Metadata
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

diff --git a/modules/dataverse-parent/pom.xml b/modules/dataverse-parent/pom.xml
@@ -200,9 +200,6 @@
 
         <!-- Container related -->
         <fabric8-dmp.version>0.43.4</fabric8-dmp.version>
-
-        <!-- Persistence -->
-        <querydsl.version>5.0.0</querydsl.version>
     </properties>
 
     <pluginRepositories>

diff --git a/pom.xml b/pom.xml
@@ -252,20 +252,6 @@
             <artifactId>expressly</artifactId>
             <scope>provided</scope>
         </dependency>
-
-        <dependency>
-            <groupId>com.querydsl</groupId>
-            <artifactId>querydsl-apt</artifactId>
-            <version>${querydsl.version}</version>
-            <classifier>jakarta</classifier>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>com.querydsl</groupId>
-            <artifactId>querydsl-jpa</artifactId>
-            <version>${querydsl.version}</version>
-            <classifier>jakarta</classifier>
-        </dependency>
 
         <dependency>
             <groupId>commons-io</groupId>

diff --git a/src/main/java/edu/harvard/iq/dataverse/DataFileTag.java b/src/main/java/edu/harvard/iq/dataverse/DataFileTag.java
@@ -58,7 +58,7 @@ public enum TagType {Survey, TimeSeries, Panel, Event, Genomics, Network, Geospa
 
     private static final Map<TagType, String> TagTypeToLabels = new HashMap<>();
 
-    public static final Map<String, TagType> TagLabelToTypes = new HashMap<>();
+    private static final Map<String, TagType> TagLabelToTypes = new HashMap<>();
 
 
     static {