Skip to content

Commit

Permalink
tests (should be passing now). #3648
Browse files Browse the repository at this point in the history
  • Loading branch information
landreev committed Mar 28, 2023
1 parent bf21975 commit 82debde
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public void testExportDataset() throws JsonParseException, IOException, ExportEx

// then
String xml = XmlPrinter.prettyPrintXml(byteArrayOutputStream.toString(StandardCharsets.UTF_8));
logger.fine(xml);
XmlAssert.assertThat(xml).isValid();
logger.severe("DDIExporterTest.testExportDataset() creates XML that should now be valid, since DDIExportUtil has been fixed.");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ void setup() {
DdiExportUtil.injectSettingsService(settingsSvc);
}


@Test
public void testJson2DdiNoFiles() throws Exception {
// given
Expand Down Expand Up @@ -74,7 +75,7 @@ public void testExportDDI() throws Exception {

// when
String result = DdiExportUtil.datasetDtoAsJson2ddi(datasetVersionAsJson);
logger.fine(result);
logger.fine(XmlPrinter.prettyPrintXml(result));

// then
XmlAssert.assertThat(result).and(datasetAsDdi).ignoreWhitespace().areSimilar();
Expand All @@ -94,7 +95,7 @@ public void testJson2ddiHasFiles() throws Exception {
String datasetAsDdi = XmlPrinter.prettyPrintXml(Files.readString(ddiFile, StandardCharsets.UTF_8));
logger.fine(datasetAsDdi);
String result = DdiExportUtil.datasetDtoAsJson2ddi(datasetVersionAsJson);
logger.fine(result);
logger.fine(XmlPrinter.prettyPrintXml(result));
boolean filesMinimallySupported = false;
// TODO:
// setting "filesMinimallySupported" to false here, thus disabling the test;
Expand Down

0 comments on commit 82debde

Please sign in to comment.