allow dataset to be created if DataCite is down #5093

IQSS · May 22, 2020 · 9cbd5d3 · 9cbd5d3
1 parent 431ee35
commit 9cbd5d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/DOIDataCiteRegisterService.java b/src/main/java/edu/harvard/iq/dataverse/DOIDataCiteRegisterService.java
@@ -130,6 +130,15 @@ public String reserveIdentifier(String identifier, Map<String, String> metadata,
                 retString = client.postMetadata(xmlMetadata);
             } catch (UnsupportedEncodingException ex) {
                 Logger.getLogger(DOIDataCiteRegisterService.class.getName()).log(Level.SEVERE, null, ex);
+            } catch (RuntimeException ex) {
+                /**
+                 * We're catching this runtime exception because we want the
+                 * dataset to be created even if DataCite is down and we can't
+                 * reserve the DOI.
+                 */
+                String msg = "Unable to reserve DOI from DataCite: " + ex.getLocalizedMessage();
+                logger.severe(msg);
+                retString = msg;
             }
         }
         return retString;

diff --git a/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractDatasetCommand.java b/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractDatasetCommand.java
@@ -187,6 +187,7 @@ protected void registerExternalIdentifier(Dataset theDataset, CommandContext ctx
                     }
                     // Invariant: Dataset identifier does not exist in the remote registry
                     globalIdServiceBean.createIdentifier(theDataset);
+                    // FIXME: Only set the create time if createIdentifier succeeded.
                     theDataset.setGlobalIdCreateTime(getTimestamp());
                     theDataset.setIdentifierRegistered(true);