Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked/Saved Search: Review Functionality + Usability Test #1840

Open
scolapasta opened this issue Apr 2, 2015 · 9 comments
Open

Linked/Saved Search: Review Functionality + Usability Test #1840

scolapasta opened this issue Apr 2, 2015 · 9 comments

Comments

@scolapasta
Copy link
Contributor

scolapasta commented Apr 2, 2015

Original post from Eleni in #2053:

In 4.0 only Super Users have the ability to Link Dataverses and Datasets and Save Searches, however we have had several users (during trainings and RT https://help.hmdc.harvard.edu/Ticket/Display.html?id=196686) ask for this functionality to be available to them so that they can do this and manage these themselves (like they did in 3.6).

@scolapasta scolapasta added this to the 4.0.1 milestone Apr 2, 2015
@scolapasta
Copy link
Contributor Author

scolapasta commented Apr 18, 2015

Among things to decide:

@scolapasta
Copy link
Contributor Author

scolapasta commented Apr 18, 2015

Re: facets, I know we'll have the manage page, but I would still like us to consider a facet (or at least index of this so we can filter by it if we want in search)

@eaquigley
Copy link
Contributor

eaquigley commented Apr 21, 2015

Would there be a way to have the publication status facet change to be "Status" and have Unpublished, Published, Draft, Linked, and Harvested appear there? @scolapasta @mcrosas @pdurbin

@mercecrosas
Copy link
Member

mercecrosas commented Apr 22, 2015

nice idea. But perhaps "status" is not the best term - how about "mode"? (but I don't feel too strong eitehr way - whatever term you prefer)

@eaquigley
Copy link
Contributor

eaquigley commented May 6, 2015

Related to #1813 #2053 #1884 #1898 #1890

@mheppler
Copy link
Contributor

mheppler commented May 6, 2015

To continue this discussion, and to help move it along for 4.0.1 development, I have reviewed all the linked workflows currently in 4.0, and where the mockups for managing are at. Here are some thoughts.

  • There is a 4.0.1 ticket for manage functionality, Linked Dataverse: Can't remove linked dataverse or dataset #1364. If we use this ticket as the high-level discussion, we could use that ticket as the specific feature development issue, and then create other feature development issues as needed. (Also, the two tickets Gustavo linked to, one Search API: Data File Citation #1335 seems to be the wrong issue, Linked Dataverse: There is no way to view a list of linked objects: dv or ds. #1365 maybe? And Linked/Saved Dataverse/Dataset - Manage Workflow #1760, he said was to be closed but is still in QA.)
  • In regards to a facet, I have mocked up a suggestion that doesn't include it with "Publication Status" because I felt this dealt with something different, and warranted it's own category title. I couldn't decide on a title, so I included both "Domain" and "Province" in the mockup, and the options are "Local" and "Linked", because I don't think you can have one facet without the other.
    screen shot 2015-05-06 at 12 22 59 pm
  • We need to review all the success and errors messages, because it looks like those haven't been fully reviewed ("...Please wait for your content to appear." What does that mean? How long do I have to wait? Do I have time to reheat this cold pizza in my fridge?).
  • We need to review Link Search workflow, and tie it into this manage workflow (Liz just commented with those related issues), so that we can manage all linked dataverses, datasets and searches in one easy to find place, that we can call "Linked Data" (just like we have "Add Data"), which you would find under "Edit Dataverse", as has been previously mocked up.
  • This one manage workflow can be laid out in a few different ways -- one big table for all linked data, separate the different types into different tables, which might be in tabs, or in collapsible panels -- so we should discuss those and decide which direction we think works best. One big table might be the easiest to develop, but could get a little messy and difficult to manage for the admin.
  • The Link Search workflow still needs some more thought too. It contains some "developie" looking options (looking at YOU "Facets") that might not make a whole lot of sense to anyone other than the developers, so might not be needed, or just need a little friendlier wording and formatting, to be useful information to the admin.
  • And, I think I found a bug, or not fully developed unexpected result of the Link Search success message. After I have linked my search for "pizza" to my dataverse in the popup, I am brought back to the dataverse landing page, with a success message, all is good there, expect that my search is no longer retained. Not sure if that was intended, but I think, since we opened the Link Search workflow in a popup, that the content/search results under the popup shouldn't be lost.

@scolapasta scolapasta modified the milestones: Candidates for 4.0.1, Design May 8, 2015
@eaquigley
Copy link
Contributor

eaquigley commented May 12, 2015

Functional Requirements Document for Linked Search: https://docs.google.com/document/d/1dmxs4XIQkrn9QfP4Ih4wIbyARUyWFJflJk3y4W3nzXk/edit?usp=sharing

@eaquigley eaquigley assigned mheppler and unassigned eaquigley May 14, 2015
@eaquigley eaquigley modified the milestones: 4.0.3, In Design Jun 25, 2015
@eaquigley eaquigley modified the milestones: 4.0.3, In Review, In Design Jul 8, 2015
@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2015

We need to review all the success and errors messages

Yes. In some cases the bundle keys aren't even present. In #2718 we learned that when Link Search fails the logs show 'Could not find key "dataverse.saved.search.failure" in bundle file' and after I fixed that regression we continue to see 'Could not find key "dataverse.saved.search.success" in bundle file' in the logs (and no success message). @eaquigley and I agreed to defer the cleanup of these bundle keys and messages until the functionality has been reviewed in this issue. I'm just leaving a note here so we don't forget.

@mercecrosas mercecrosas modified the milestones: In Design, In Review Nov 30, 2015
@mheppler mheppler removed their assignment Jan 7, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
pdurbin added a commit that referenced this issue Sep 15, 2016
In a refactoring at c10cbd9 we lost the meaning of 0.0.0.0 which was
"Setting address to undefined (0.0.0.0)" so this commit makes the code
clearer.

A note has been added that Saved Search may not play nicely with IP
Groups but this should probably be addressed along with the long list of
other Saved Search issues mentioned in the API Guide: #1364, #1813,
 #1840, #1890, #1939, #2167, #2186, #2053 and #2543
@pdurbin
Copy link
Member

pdurbin commented Jun 29, 2017

I forgot that I did a little bit of work on this at d110ce2. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants