-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a dataverse administrator, I want to remove my name from contributors list of a dataset version #6274
Comments
A temporary workaround can be to delete rows from datasetversionuser table. What do you think about that ? |
Hi @tcoupin, in #5541 there were changes that allowed updates to be made by superusers without making a version change. This was included with 4.12. I'd suggest using this feature instead of removing records that were created. I acknowledge that the use case that you present is slightly different, but I'm concerned about providing extended functionality in this area because each additional option for editing without a record reflected in the versions view takes away from what the versioning system was meant to support in the first place. Suggestions/discussion welcome! |
Hey @djbrooke, |
Hi @tcoupin, I'm not sure I understand. Are you saying that you are able to use the feature to publish without incrementing the version, but your name still appears on the contributor list? |
Yes. I test on a new dataset with 2 accounts, one as simple user and one as superuser.
… Le 18 oct. 2019 à 19:26, Danny Brooke ***@***.***> a écrit :
Hi @tcoupin, I'm not sure I understand. Are you saying that you are able to use the feature to publish without incrementing the version, but your name still appears on the contributor list?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Thanks @tcoupin, I just tested this in this way:
A new version was not created (as expected) and I did see the superuser account added to the contributors list as you mention. @qqmyers and @adam3smith, do you have any thoughts on this? I suppose I was expecting for the superuser account to not be added to the contributors list for the current version, but thinking about it more, this is correct and makes sense. Just wondering if it came up as you were developing #4760/#5541. |
I can see both sides of this. A change was made to that version, so we should track it as if it had happened when in draft. But I also see the idea of having a superuser make changes for the contributor and not needing to show up as a contributor. I've seen other applications were a superuser could log in "as" another user. Not sure if that's kind if functionality is overkill for this or even wanted generally. |
The Contributors as listed in the versions table are not the Creators listed in the dataset metadata and the citations. Would changing the labeling, or what's displayed in the table resolve the issue (versus actually changing who is considered a Contributor to the dataset object in Dataverse)? In some sense, who contributed in Dataverse is not the same kind of info as the rest (i.e. it's only interesting to someone tracking use in Dataverse as opposed to someone coming in to check out the data), so perhaps it should not appear in the Versions table. Or be a column that appears only for admins, or is on a separate admin/mgmt tab, etc. (FWIW, the work to do archiving is similar (mostly of interest to admins/curators/managers) and for QDR, we've (for now) added a column to the versions tab that shows whether the archival copy exists (or not) that only shows for admins. If there start to be several things are management-related, perhaps a separate mgmt/admin tab would be the better option). |
I want the information captured and I think having a log of who made changes, including to metadata, is the right way to go (it certainly is for us). Completely agree with @qqmyers though that the label may need a change to avoid confusion between this and the metadata label of the same name. How about "Edited by"? |
Hi everyone,
Seems to me is that what matters here is ROLES as much as the specific USERS who make these changes. We may want to describe the roles of different contributors to the publications process. It would be good to be able to describe a contributor's role (using a controlled vocabulary - e.g. CREDIT https://www.casrai.org/credit.html) and detail the changes that they have made.
Some are high-level (a dataset creation or edit), some are very minor - it may be good to display the changes associated with a given type of role??
Cheers,
Steve
…----------------------------------------------
Dr. Steven McEachern
Director, Australian Data Archive
Australian National University
Ph. (+61)2 6125 2200
E: steven.mceachern@anu.edu.au
http://www.ada.edu.au
----------------------------------------------
________________________________
From: Sebastian Karcher <notifications@github.com>
Sent: Sunday, 20 October 2019 2:44 AM
To: IQSS/dataverse <dataverse@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [IQSS/dataverse] As a dataverse administrator, I want to remove my name from contributors list of a dataset version (#6274)
I want the information captured and I think having a log of who made changes, including to metadata, is the right way to go (it certainly is for us).
Completely agree with @qqmyers<https://github.com/qqmyers> though that the label may need a change to avoid confusion between this and the metadata label of the same name. How about "Edited by"?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#6274?email_source=notifications&email_token=AAJK2U2W6CFEAHC4LFX3VJTQPMTOVA5CNFSM4JA3OZNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXUFVI#issuecomment-544162517>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJK2UZSYKBS5CCMORPVHKDQPMTOVANCNFSM4JA3OZNA>.
|
Thanks all for the discussion here. I hear the arguments about a label change being a possibility here, but I also like "contributors" because it recognizes the act of curation as a contribution, not just editing (I think I'm echoing @stevenmce). I encourage further conversation here but making changes in this section isn't something that's currently a priority. @tcoupin, the team at IQSS has other priorities right now and we can't really dig into this in detail from a design perspective. In the short term, we'd also want to avoid any PRs that remove contributors (even those just API based). We don't want to add something right now that will make it harder to support workflows for sensitive data in the future, which require auditing and other characteristics. A DB edit may meet your needs but I'm not sure. |
A DB edit can solve any problem. :) But yes, in this case, it's straightforward delete from one table and there are no dependencies on those rows, so you can definitely do manual db deletes for this. |
Maybe in the short term we could add a tool tip that clarifies the term "Contributors" as used in the versions table. |
I'm going to close this for now since we won't be making changes, but we can of course reference it in the future. |
Hello everybody, @djbrooke explained that several things discussed here entail large-scale changes and that they're not priorities at the moment, and I took good note of that. But I just wanted to make a few suggestions in case they can help in future discussions.
|
This issue seems to be a decent place for me to write up some behavior I noticed while working on #4475. The ReturnDatasetToAuthorCommand calls updateDatasetUser which adds a row to the All this is to say that in some cases curators might be noticing their names under "Contributors" not because they edited the dataset but because they clicked "Return to Author" (the second half of the "Submit for Review" workflow). Here's the code mentioned above: https://github.com/IQSS/dataverse/blob/v5.3/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/ReturnDatasetToAuthorCommand.java#L47 |
Hi, @eunices, yes, deleting directly the rows from that table should be OK. It would be nice if we had a superuser API though, as that would of course allow less room for error. But in the meanwhile, deleting manually is the way to do this. |
All editors of a dataset appears in contributors list of the published dataset version.
On the following snapshot, only the scientist should be displayed (Christian DEPRAETERE) et not the administrators who make only small adjustements.
The text was updated successfully, but these errors were encountered: