Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted files showing up as duplicates when granting permissions, Add path if it exists #6587

Closed
sbarbosadataverse opened this issue Jan 28, 2020 · 5 comments · Fixed by #6659
Assignees

Comments

@sbarbosadataverse
Copy link

There seems to be this continuous issue when files are deleted from a dataset and what shows up under permissions. Some files from this dataset shows up twice under the "permissions-file" dialogue box so I am never sure if I am giving permissions to a an old deleted file or the file in the most recent published version. Very confusing!

Screen Shot 2020-01-28 at 5 51 10 PM

@scolapasta
Copy link
Contributor

@sbarbosadataverse we had an issue (#6401) where you couldn't assign / remove permissions for files that had the same name as a deleted file. I believe the change that fixed that has also inadvertently added those deleted files to this list. We can add logic to only show current files.

@sbarbosadataverse
Copy link
Author

@scolapasta when you scroll down further on the permissions page, it still continues to show deleted files and I thought this was going to be fixed as well.

Screen Shot 2020-01-29 at 12 15 49 PM

@djbrooke djbrooke changed the title file level permissions: file names are showing up twice on permissions page when granting access File names are showing up twice on permissions page when granting access, deleted files also shown Jan 29, 2020
@djbrooke djbrooke changed the title File names are showing up twice on permissions page when granting access, deleted files also shown Deleted files showing up as duplicates when granting permissions Jan 29, 2020
@djbrooke djbrooke moved this from Ready 🙋 to IQSS Sprint 2/5 - 2/19 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 5, 2020
@djbrooke djbrooke assigned scolapasta and djbrooke and unassigned scolapasta Feb 5, 2020
@djbrooke djbrooke changed the title Deleted files showing up as duplicates when granting permissions Deleted files showing up as duplicates when granting permissions, Add path if it exists Feb 5, 2020
@djbrooke
Copy link
Contributor

djbrooke commented Feb 5, 2020

  • This could be related to either replacing or deleted files, a solution to both would be to filter by unique IDs
  • We should add the file path when we're in this code, in support of files with the same name

@djbrooke djbrooke added the Medium label Feb 5, 2020
@djbrooke djbrooke removed their assignment Feb 5, 2020
@sekmiller sekmiller moved this from IQSS Sprint 2/5 - 2/19 to IQSS Team Dev 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 6, 2020
@sekmiller sekmiller self-assigned this Feb 6, 2020
@djbrooke djbrooke moved this from IQSS Team Dev 💻 to IQSS Sprint 2/5 - 2/19 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 10, 2020
@sekmiller sekmiller moved this from IQSS Sprint 2/5 - 2/19 to IQSS Team Dev 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 10, 2020
@sekmiller sekmiller self-assigned this Feb 10, 2020
sekmiller added a commit that referenced this issue Feb 11, 2020
hard-coded to false for now
@mheppler
Copy link
Contributor

Talked to @sekmiller and @scolapasta about this deleted file issue and if was also related to an older issue, Some files not showing up in file permission list #3726, and Gustavo suggested that it was fixed in PR #6402 for issue Files with same name break permissions page #6401.

Stephen said he could confirm that, as @sbarbosadataverse was asking about it recently as well.

The comment from @scolapasta on #3726 was:

In the Manage file permission list, some files are not showing up. This seems to be related to the fact that the same file (same name and md5) was removed and re-added.

Example dataset (if you have manage permissions permissions):
https://dataverse.harvard.edu/permissions-manage-files.xhtml?id=48000

@mheppler
Copy link
Contributor

Confirmed. Thank you, @sekmiller.

Based on what I'm seeing in my branch, I would say that 6401 and 3726 were fixed by PR 6402. My branch is just extending that fix by filtering out deleted files(by default) and allowing you to see them via a check box on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants