Upload file to published version (creating a draft) incorrectly allows same file name

[scolapasta]

1. Start from a published dataset (with files)
2. Upload a file with the same name as an existing file.
   2a. (notice the name does not get auto changed)
3. save.

The save succeeds, when it shouldn't, and you're left with a dataset with two files with the same path+name.

Expected behavior: file should be auto renamed when uploaded.

[scolapasta]

Also can we have a db unique constraint on columns datasetversion_id, directorylabel, and label of the filemetadata table? That way db would never allow.

[sekmiller]

If I run this query on my 3 month old copy of production data I find that there are about 350 dataset versions effected, some 311 Released, 25 in Draft and 18 Deaccessioned :

select versionstate, count() from datasetversion where id in
(select datasetversion_id from filemetadata
group by label, directorylabel, datasetversion_id
having count() > 1)
group by versionstate

[sekmiller]

Also some 1500 or so file metadata combinations are involved when querying only released versions. Over 200 have more than two name/directory/version duplicates. Bottom line: I don't think it's feasible to try to clean this up and add the constraint in Dataverse 5.0