Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked dataverses dont (always) show up in their linking dataverses #7430

Closed
AACGSR opened this issue Nov 19, 2020 · 14 comments
Closed

Linked dataverses dont (always) show up in their linking dataverses #7430

AACGSR opened this issue Nov 19, 2020 · 14 comments
Assignees
Labels
Size: 80 A percentage of a sprint. 56 hours.
Projects
Milestone

Comments

@AACGSR
Copy link
Contributor

AACGSR commented Nov 19, 2020

Very closely related to:

Our Dataverses hierarchy goes root - level 1 - level 2 - level 3. All three levels have multiple dataverses.

Many linked dataverses dont appear in their linking dataverses. The link Dataverse API gives back 200 and a database entry is added properly, yet they don't show up being linked in those dataverses. Neither reindexing the linking dataverses nor a full reindex helps with this.

Linking level 1 into level 1 works.
Linking level 2 into level 1 works.
Linking level 3 into level 1 works.

Linking level 1 into level 3 doesnt work.
Linking level 2 into level 3 doesnt work.
Linking level 1 into level 2 doesnt work.
Linking level 2 into level 2 doesnt work.
Linking level 3 into level 3 doesnt work.
Linking level 3 into level 2 doesnt work.

We assume that linking a superior level dataverse into a subordinated dataverse does not work as a feature, since it's considered to be unlogical (please correct me if this should work).
However this doesnt explain all of the "doesnt work" lines above.

@djbrooke
Copy link
Contributor

Hi @AACGSR - it's possible that you're running into this issue, just on a Dataverse instead of a Dataset:

#7259

Can you see if there are multiple entries in the DB?

@AACGSR
Copy link
Contributor Author

AACGSR commented Nov 20, 2020

Thanks @djbrooke

Indeed there was a double entry I did know about (the first time the linked dataverse didnt show up, I linked it via GUI, and retried using the API for the same link, which resulted in two rows in the DB). However, every other link that failed only has one DB entry. I just deleted the 2nd row of the double entry and ran a reindex. Unfortunately, that did not help.

@pdurbin
Copy link
Member

pdurbin commented Nov 20, 2020

I just wanted to mentioned I fixed the double row/entry problem in 5d4a3dc in pull request #7415 but it hasn't been merged yet.

@pdurbin
Copy link
Member

pdurbin commented Nov 20, 2020

Linking level 2 into level 2 doesnt work.

I can confirm that this doesn't work (and I assume deeper levels don't work either). In 403a966 for pull request #7415 I wrote some tests to exercise this. Hopefully they will be a good starting point when we pick this up.

@kcondon
Copy link
Contributor

kcondon commented Nov 20, 2020

I'm assuming the test cases are between two separate dataverses so linking level 1 of dv1 to level 1 of dv2, level 2 of dv1 (dv1_1) into level 2 of dv2 (dv2_1)?

While testing the duplicate linking pr, I did find you could link a parent dv into a child dv, which I don't think should be allowed, eg. linking dv1 into dv1_1. That is possible in both the UI and API. Also, linking in this case reports success but then the parent dv, in this example dv1, doesn't appear in the ui in the child, dv1_1. In a separate slack note, Gustavo thought it could be argued that allowing a parent to link to a child might be acceptable so it make me wonder whether at some point this was by design because it also exists in the UI.

@AACGSR
Copy link
Contributor Author

AACGSR commented Nov 23, 2020

I'm assuming the test cases are between two separate dataverses so linking level 1 of dv1 to level 1 of dv2, level 2 of dv1 (dv1_1) into level 2 of dv2 (dv2_1)?

Exactly!

@pdurbin pdurbin added this to Watching in pdurbin May 13, 2022
@plesubc
Copy link

plesubc commented May 13, 2022

UBC is experiencing similar behaviour with Dataverse v5.6 (cf: https://groups.google.com/g/dataverse-community/c/DDmVelt3Zfk)

Note that this behaviour is not limited to our production server; it also occurs on our test server with newly created collections and data sets. Generally speaking, the linking we are generally using is with datasets on the same hierarchy.

root
collection A
collection B
collection C
collection D

Collections B and C, if linked to A, show only the collection title but no contents. Even if collection D is linked directly to A, there are no contents displayed, even though D is one level down.

@pdurbin
Copy link
Member

pdurbin commented May 20, 2022

@mreekie
Copy link

mreekie commented May 23, 2022

priority:

  • This came in from a customer this week.
  • Brought in by Gustavo.

@mreekie
Copy link

mreekie commented May 25, 2022

@scolapasta - is this part of the harvesting feature?

@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

@mreekie no, this is unrelated to harvesting.

Here are the docs on collection linking: https://guides.dataverse.org/en/5.12/user/dataverse-management.html#dataverse-collection-linking

According to the docs (and I have no reason to doubt this), it's still a superuser-only feature.

Both Saved Search and Linking are still technically experimental according to the API Guide: https://guides.dataverse.org/en/5.12/api/native-api.html#saved-search

@mreekie mreekie added the bk2211 label Nov 1, 2022
@mreekie
Copy link

mreekie commented Dec 12, 2022

Sizing:

@mreekie
Copy link

mreekie commented Jan 4, 2023

sizing discussion here

This one is sized at an 80 since it could be more complex.
This could involve a lot of testing to get to the root of the problem and also as part of qa

@mreekie mreekie added the Size: 80 A percentage of a sprint. 56 hours. label Jan 4, 2023
@mreekie mreekie removed the bk2211 label Jan 11, 2023
@mreekie mreekie added this to This Sprint 🏃‍♀️ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Jan 11, 2023
@sekmiller sekmiller moved this from This Sprint 🏃‍♀️ to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 13, 2023
@sekmiller sekmiller self-assigned this Jan 13, 2023
@pdurbin
Copy link
Member

pdurbin commented Jan 23, 2023

closed by this PR:

@pdurbin pdurbin closed this as completed Jan 23, 2023
@pdurbin pdurbin added this to the 5.13 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 80 A percentage of a sprint. 56 hours.
Projects
Status: No status
pdurbin
Watching
Development

No branches or pull requests

7 participants