Helper method for setting required fields (e.g. distributorContact) on a dataset version

[pdurbin]

@sekmiller and I just discussed how it would probably be worthwhile to have a helper method to set fields that are required, such as title, authorName, distributorContact, dsDescription, and subject.

That is, I'd love to have something like

newDatasetVersion.setTitle("fooTitle");

rather than...

List<DatasetField> datasetFields = new ArrayList<>();
DatasetField titleDatasetField = new DatasetField();
DatasetFieldType titleDatasetFieldType = datasetFieldService.findByName("title");
titleDatasetField.setDatasetFieldType(titleDatasetFieldType);
List<DatasetFieldValue> datasetFieldValues = new ArrayList<>();
DatasetFieldValue titleDatasetFieldValue = new DatasetFieldValue(titleDatasetField, "fooTitle");
datasetFieldValues.add(titleDatasetFieldValue);
titleDatasetField.setDatasetFieldValues(datasetFieldValues);
datasetFields.add(titleDatasetField);
newDatasetVersion.setDatasetFields(datasetFields);

(which I was doing

dataverse/src/main/java/edu/harvard/iq/dataverse/api/datadeposit/CollectionDepositManagerImpl.java

Line 143 in 5226693

List<DatasetField> datasetFields = new ArrayList<>();

)

[scolapasta]

There are already some generic helper methods (and I had updated the sword code to use). @pdurbin do you feel we need more?

[pdurbin]

I'd love to have something like

newDatasetVersion.setTitle("fooTitle");

We don't have what I wished for above... the code looks more like this...

DatasetFieldType emailDatasetFieldType = datasetFieldService.findByNameOpt(DatasetFieldConstant.datasetContact);
DatasetField emailDatasetField = DatasetField.createNewEmptyDatasetField(emailDatasetFieldType, datasetVersion);
for (DatasetField childField : emailDatasetField.getDatasetFieldCompoundValues().get(0).getChildDatasetFields()) {
    if (DatasetFieldConstant.datasetContactEmail.equals(childField.getDatasetFieldType().getName())) {
        childField.getSingleValue().setValue(user.getDisplayInfo().getEmailAddress());
    }
}
datasetVersion.getDatasetFields().add(emailDatasetField);

... which is better but still a fair amount of code for adding a value, in my opinion. I'll give this back to @scolapasta since he asked me to comment. Do with this ticket what you will. It certainly isn't user-facing. :)

[scolapasta]

OK, we'll consider for later, if we need anything more.

[raprasad]

this is cobol:)

DATA DIVISION.
   WORKING-STORAGE SECTION.
   01 TITLE PIC X(100) VALUE 'FOOTITLE'.

[eaquigley]

Passing to QA to close (@kcondon) per @scolapasta

[kcondon]

Closing