Major Update to Metadata blocks #1114
Comments
posixeleni
added
Type: Feature
posixeleni
changed the title
posixeleni
changed the title
posixeleni
changed the title
|
@pdurbin this will need a schema.xml change. I had to commit this in now to help with @ekraffmiller import work. Please let me know if anything is unclear. Thanks! |
|
Ok, I updated the Solr schema.xml in 9265f8e @posixeleni remember when you used to push your changes in a branch? And test in Vagrant? That was awesome because it meant I wouldn't have to immediately update the Solr schema. The minute you update the tsv files it affects dvn-build and developers the next time they pull. My search tests are currently broken. Unfortunately, I can no longer create a dataset using the JSON at https://github.com/IQSS/dataverse/blob/master/scripts/search/tests/data/dataset-finch1.json (I'm getting the exception below). @posixeleni do you want to see if you can adjust that JSON to make it work? I'm giving this ticket back to you. |
|
@pdurbin I don't understand what the JSON is outputting above. @scolapasta is there any chance you can help me figure out what is causing this issue? I had to make several major changes to support DDI-Lite and this includes changing how the Dataset Contact is mapped (see my first comment at the top). Could this be the cause? Thanks! |
|
Please note that these changes would also require a database drop. |
|
@pdurbin & @posixeleni - looks like the change is that one of the fields we have change to allowMultiples= true, is in one of the Json data test files. When allowMultiples= true, then the Json data has to store the value in an array, rather than a simple string. Phil, I can look at the data with you and find where the problem is. |
|
Not sure if this is connected but JSON that had been parsing fine for months "broke" on me yesterday.
Object worldmapTokenObject = jsonTokenInfo.get(WorldMapToken.GEOCONNECT_TOKEN_KEY);
if (worldmapTokenObject==null){
logger.warning("Token is null found. Permission denied.");
return null;
}
String worldmapTokenParam = worldmapTokenObject.toString();
String worldmapTokenParam = jsonTokenInfo.getString(WorldMapToken.GEOCONNECT_TOKEN_KEY);
if (worldmapTokenParam==null){ // shouldn't happen
logger.warning("worldmapTokenParam is null when .toString() called. Permission denied.");
return null;
}\cc @pdurbin |
|
The update to the Dataset Contact (making it a compound field) broke the create dataset page. I just checked in a fix that will allow you create a dataset via the interface. NOTE: I did a dbdrop/ re-run setup-all.sh to get this to work…. On Dec 9, 2014, at 10:23 AM, Raman Prasad <notifications@github.commailto:notifications@github.com> wrote: Not sure if this is connected but JSON that had been parsing fine for months "broke" on me yesterday.
Object worldmapTokenObject = jsonTokenInfo.get(WorldMapToken.GEOCONNECT_TOKEN_KEY);
String worldmapTokenParam = jsonTokenInfo.getString(WorldMapToken.GEOCONNECT_TOKEN_KEY); \cc @pdurbinhttps://github.com/pdurbin — |
|
@ekraffmiller please reassign to @pdurbin or me if the JSON is sorted out Thanks so much for your help! |
|
Ok, json updated. |
Per #1114 needed to remove sample frame which @ekraffmiller brought to my attention that this was not done yet. @pdurbin this may need a schema.xml change and another db drop whenever you're ready since I had to drop a pre-existing field.
In #921 (comment) we said...
... and now we need to adjust the addDatasetContact method in https://github.com/IQSS/dataverse/blob/master/src/main/java/edu/harvard/iq/dataverse/api/datadeposit/SwordServiceBean.java to properly enter the value. I get so lost in updating dataset fields (which is why I opened #761) that I'm hoping @scolapasta or @sekmiller can fix that method. Passing this ticket to @scolapasta (There's a new related ticket about how datasets with no contact email address shouldn't have been allowed to be created in the first place #1237 .) |
|
This is fixed now, |
other changes are a no-op, an artifact of sorting on Mac vs. Linux?
|
I saw in b9ef7b8 that @posixeleni slipped another tsv change it and I just updated the Solr schema in 5c786bd but since a field was removed, not added, people don't need to update the Solr schema. I'm sure it will be updated soon enough. |
|
Hmm, I should note that @posixeleni mentions the possibility of a db drop at b9ef7b8 but I don't know if this is required. |
|
@posixeleni I saw the following issues, can you comment? Otherwise tested all changes and verified changed fields are usable and searchable. |
|
Closing unless I hear otherwise. |
|
@kcondon to answer your questions (let me know if anything is unclear):
Please let me know if I can assist with anything else. |
djbrooke
added this to QA 👍
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
In order to make sure we are DDI-Lite compliant I am working on modifying the metadata blocks in Dataverse prior to 4.0.
Under Citation Block
Under Social Science Block
Under Geospatial Block
The text was updated successfully, but these errors were encountered: