Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Password button does not result in info banner feedback, shows no feedback in develop branch #7677

Closed
kcondon opened this issue Mar 11, 2021 · 6 comments · Fixed by #7842
Assignees

Comments

@kcondon
Copy link
Contributor

kcondon commented Mar 11, 2021

Go to forgot your password, enter email, click Submit Password Request button and get no feedback where on demo/5.3 you get an info message saying it was sent if email exists.

@djbrooke
Copy link
Contributor

Thx @kcondon. I reported this in #7106 but it's been frustratingly intermittent. I'll move to up next so we can dig in.

@kcondon
Copy link
Contributor Author

kcondon commented Apr 23, 2021

So, after discussing with Stephen, found that disabling the updated google analytics code allowed it to work again: https://guides.dataverse.org/en/5.4.1/installation/config.html#web-analytics-code

Is this a case of the analytics code breaking the event handling/listener on the page? I don't know how that works so am speculating ;)

@sekmiller
Copy link
Contributor

I added web analytics to my local environment, but I am still seeing the proper messaging on reset password.

@qqmyers
Copy link
Member

qqmyers commented Apr 28, 2021

FWIW: There was a time when the analytics code examples caused trouble - I think because they didn't have everything in CDATA blocks, so it's possible that out of date versions would break this and the latest wouldn't.

@sekmiller
Copy link
Contributor

@qqmyers as a test I took out the CDATA blocks and now the messaging works. So what was the issue that adding it was trying to solve?

@qqmyers
Copy link
Member

qqmyers commented Apr 29, 2021

#5967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants