Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API call to deaccession datasets #778

Closed
pdurbin opened this issue Jul 28, 2014 · 5 comments
Closed

API call to deaccession datasets #778

pdurbin opened this issue Jul 28, 2014 · 5 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2014

Deaccessioning of datasets was implemented in #600 and related tickets but it's a GUI-only operation.

The Data Deposit API in DVN 3.x supported deaccessioning but in a meeting we talked about deprecating this feature because a reason for deprecation can not be given. For now, when this operation is attempted we'll link to this ticket or otherwise indicate that is or will be a feature of the "native" API.

Selfishly, I'd like an API call sooner rather that later so I can easily test deaccessioning programmatically.

@pdurbin pdurbin added this to the In Review - Dataverse 4.0 milestone Jul 28, 2014
@eaquigley eaquigley modified the milestones: In Review - Dataverse 4.0, Beta 8 - Dataverse 4.0 Sep 3, 2014
@pdurbin pdurbin added this to the Beta 8 - Dataverse 4.0 milestone Oct 21, 2014
@pdurbin pdurbin self-assigned this Oct 21, 2014
@eaquigley eaquigley modified the milestones: Post 4.0, Beta 11 - Dataverse 4.0 Jan 7, 2015
@scolapasta scolapasta modified the milestones: In Review - Long Term, In Review - Short Term May 8, 2015
@pdurbin pdurbin removed their assignment Jan 20, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin
Copy link
Member Author

pdurbin commented Apr 29, 2016

I just wanted to mention that when hacking around on Private URL in #1012 today I definitely noticed that there is (unfortunately) business logic having to do with deaccessioning that exists only in the GUI, especially setDatasetVersionDeaccessionReasonAndURL at https://github.com/IQSS/dataverse/blob/v4.3/src/main/java/edu/harvard/iq/dataverse/DatasetPage.java#L1994 but perhaps other places as well. Code like this needs to be centralized so it can be used from the API as well.

In #2746 we started an effort toward automated testing and the inability to deaccession datasets via API inhibits our ability to test in this area.

@kcondon
Copy link
Contributor

kcondon commented May 9, 2016

We should do a gap analysis between UI and API to catch any other missing endpoints.
Seems to have value for automated testing, code refactoring, and possibly more comprehensive future integration with other publishing systems.

@pdurbin
Copy link
Member Author

pdurbin commented May 9, 2016

For the gap analysis, it's also impossible to restrict files via API: #2497. This makes it impossible to write API tests for this. I'm pretty sure a lot of guestbook stuff is also GUI only.

@pdurbin
Copy link
Member Author

pdurbin commented Jul 12, 2018

Closing in favor of this list I'm maintaining: No functionality should be GUI-only. Make all functionality reachable via the API #3440

@pdurbin pdurbin closed this as completed Jul 12, 2018
@pdurbin
Copy link
Member Author

pdurbin commented Oct 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants