Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Citation block placeholders are too long to view #9022

Open
qqmyers opened this issue Oct 4, 2022 · 2 comments
Open

New Citation block placeholders are too long to view #9022

qqmyers opened this issue Oct 4, 2022 · 2 comments

Comments

@qqmyers
Copy link
Member

qqmyers commented Oct 4, 2022

The placeholder text for several child fields in the citation block are now longer than the input box that contains them, e.g.
image

Since the placeholder text doesn't scroll, it can be read in full.

What steps does it take to reproduce the issue?
Edit dataset metadata and read the placeholder on fields like the ones shown. Seen on Chrome/Windows.

Which version of Dataverse are you using?
5.11.1/5.12

A quick workaround is to add custom CSS to expand these subfields. For example,

div:has(> input[placeholder='1) FamilyName, GivenName or 2) Organization']) {
    width:100%;
}

changes fields with that placeholder to look like this:
image

Since this can be done in custom CSS, sites could fix this on their own. However,

  1. it seems like it should work by default, so it would be good to fix this in the distribution, and
  2. if there isn't a non-CSS solution, it might help to add an id to the metadata fields that would simplify the CSS selector needed. The one above would have to be replicated for other i18n languages and would break when the placeholder changes. An id="producer-name' or similar would make it easier to target this field (but a placeholder selector might be desired if some i18n translations are much shorter/longer?)
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this issue Oct 5, 2022
@poikilotherm
Copy link
Contributor

poikilotherm commented Oct 6, 2022

FWIW:

Maybe all fields should have a CSS class attached to them, derived from the schema TSV field name? (It seems they don't have right now?)

The id of each field should be unique. Not sure how Primefaces handles the id when you add more items via the "+".

I also remember that folks mentioned it would be nice to have easier access to fields for UI testing.

@qqmyers
Copy link
Member Author

qqmyers commented Oct 6, 2022

Good point - class would have to be used for fields that allow multiple.

qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this issue Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants