Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset Json Validation: Update the code to use this schema #9464

Closed
kcondon opened this issue Mar 22, 2023 · 0 comments · Fixed by #10109
Closed

Dataset Json Validation: Update the code to use this schema #9464

kcondon opened this issue Mar 22, 2023 · 0 comments · Fixed by #10109
Assignees
@sekmiller
Labels
D: ImproveJsonValidation https://github.com/IQSS/dataverse-pm/issues/26 Size: 10 A percentage of a sprint. 7 hours.
Milestone
6.1

Comments

@kcondon
Copy link
Contributor

kcondon commented Mar 22, 2023

This is the second step in addressing: IQSS/dataverse-pm#26

Use this schema to update the code. We currently have a library that checks the JSON schema (wc3provenance schema). As part of this solution we should not feel limited to using our current library. (On the page about the JSON schema there are multiple java library options available for validation.)(10)
@kcondon kcondon mentioned this issue Mar 22, 2023
Closed
@kcondon kcondon added the Size: 10 A percentage of a sprint. 7 hours. label Mar 22, 2023
@mreekie mreekie added the D: ImproveJsonValidation https://github.com/IQSS/dataverse-pm/issues/26 label Mar 22, 2023
@cmbz cmbz added this to the 6.1 milestone Sep 18, 2023
@sekmiller sekmiller moved this from ▶ SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Oct 26, 2023
@sekmiller sekmiller mentioned this issue Oct 30, 2023
Closed
@sekmiller sekmiller self-assigned this Oct 30, 2023
@sekmiller sekmiller moved this from This Sprint 🏃‍♀️ 🏃 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Oct 30, 2023
@sekmiller sekmiller added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) and removed Size: 10 A percentage of a sprint. 7 hours. labels Oct 30, 2023
sekmiller added a commit that referenced this issue Nov 1, 2023
@sekmiller
#9464 create json
61abac1
sekmiller added a commit that referenced this issue Nov 2, 2023
@sekmiller
#9464 fix json schema formatting
38f09f6
sekmiller added a commit that referenced this issue Nov 2, 2023
@sekmiller
#9464 remove license from required
5ca4cc0
sekmiller added a commit that referenced this issue Nov 8, 2023
@sekmiller
#9464 Add commands, endpoints, IT, etc
02a570a
sekmiller added a commit that referenced this issue Nov 8, 2023
@sekmiller
#9464 delete test dataverse
521e8d2
sekmiller added a commit that referenced this issue Nov 8, 2023
@sekmiller
#9464 add release note
7c630f7
@cmbz cmbz added Size: 10 A percentage of a sprint. 7 hours. and removed Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Nov 8, 2023
sekmiller added a commit that referenced this issue Nov 8, 2023
@sekmiller
#9464 fix typo
7be5347
sekmiller added a commit that referenced this issue Nov 9, 2023
@sekmiller
#9464 add doc for validate json
a080f84
@sekmiller sekmiller mentioned this issue Nov 9, 2023
Merged
sekmiller added a commit that referenced this issue Nov 9, 2023
@sekmiller
#9464 add strings to bundle
7d38366
sekmiller added a commit that referenced this issue Nov 9, 2023
@sekmiller
#9464 simplify commands
7887a05
sekmiller added a commit that referenced this issue Nov 13, 2023
@sekmiller
#9464 remove unused import
437e7cc
sekmiller added a commit that referenced this issue Nov 17, 2023
@sekmiller
#9464 query by dvo. update IT
73593ac
sekmiller added a commit that referenced this issue Nov 20, 2023
@sekmiller
#9464 fix logger reference
e4ede35
sekmiller added a commit that referenced this issue Nov 20, 2023
@sekmiller
#9464 add base schema as a file
766c9c3
sekmiller added a commit that referenced this issue Nov 21, 2023
@sekmiller
#9464 fix formatting
c82faf9
sekmiller added a commit that referenced this issue Nov 21, 2023
@sekmiller
#9464 more code cleanup
44a07a3
sekmiller added a commit that referenced this issue Nov 21, 2023
@sekmiller
#9464 third time's the charm?
7d687e9
pdurbin added a commit that referenced this issue Nov 27, 2023
@pdurbin
add dataset JSON Schema to API guide, add test #9464
fff754e
sekmiller added a commit that referenced this issue Nov 27, 2023
@sekmiller
#9464 return json object as api response
212baf2
sekmiller added a commit that referenced this issue Nov 27, 2023
@sekmiller
#9464 revert harvesting changes made in error
9367026
pdurbin added a commit that referenced this issue Nov 27, 2023
@pdurbin
add dataset JSON Schema to API guide, add test #9464
b7a3e78
pdurbin added a commit that referenced this issue Nov 27, 2023
@pdurbin
just return the JSON Schema, don't wrap in "data, message" #9464
2d3f7ab
pdurbin added a commit that referenced this issue Nov 27, 2023
@pdurbin
tweak docs #9464
0a77e2a
pdurbin added a commit that referenced this issue Nov 27, 2023
@pdurbin
removing trailing newline #9464
7db3629
pdurbin added a commit that referenced this issue Nov 28, 2023
@pdurbin
remove cruft (unused) #9464
194945b
pdurbin added a commit that referenced this issue Nov 28, 2023
@pdurbin
format code (no-op) #9464
c1bd009
pdurbin added a commit that referenced this issue Nov 28, 2023
@pdurbin
add new endpoints to API changelog #9464
c4d9b6e
pdurbin added a commit that referenced this issue Nov 28, 2023
@pdurbin
tweak release note #9464
45df764
pdurbin added a commit that referenced this issue Nov 28, 2023
@pdurbin
add "v" to make anchor links meaningful #9464 #10060
d8e327d 
Anchors like #v6.1 are much better than #id1, which is meaningless.
sekmiller added a commit that referenced this issue Dec 4, 2023
@sekmiller
#9464 add more detail to validation error message
547d71c
sekmiller added a commit that referenced this issue Dec 4, 2023
@sekmiller
#9464 handle single errors
7697157
sekmiller added a commit that referenced this issue Dec 5, 2023
@sekmiller
#9464 add caveats to release note.
c54a85f
@sekmiller sekmiller mentioned this issue Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekmiller sekmiller

Labels
D: ImproveJsonValidation https://github.com/IQSS/dataverse-pm/issues/26 Size: 10 A percentage of a sprint. 7 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

JSON Schema creator and validator IQSS/dataverse
4 participants
@sekmiller @kcondon @cmbz @mreekie