8549 collection quotas #10174
Merged
8549 collection quotas #10174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
approved these changes
Dec 11, 2023
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
landreev
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
landreev
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
landreev
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
I waited for the Jenkins test to pass. I tested it some too. Will just go ahead and merge it - ? |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a followup PR to #10144 - a small refinement I remembered to add after the fact.
It's for counting the sizes of any new "registered aux. files" - like the ones that an external tool like OpenDP would deposit, etc.; it makes sense to consider these real data payload, unlike the throwaway aux. files like exports and thumbnails.
This was discussed on slack, outside of the issue/PR, so slipped through the cracks.
If it's too late to merge, it's probably just fine. It's extremely unlikely that these would ever amount to a statistically important amount of storage on any instance actively using aux. files.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
A simple and quick way to test this would be to upload the netcdf file from our source tree
src/test/resources/netcdf/ICOADS_R3.0.0_1662-10.ncand check that the storage use for the parent collection got incremented by a few bytes (viacurl -H "X-Dataverse-key: xxx" http://localhost:8080/api/dataverses/<COLLECTIONALIAS>/storage/useor a db query). The special treatment of NetCDF is one scenario in our own prod. where registered aux. files are created.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: