#10271 fix tool tests w/arrays #10311
Merged
+59
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
This PR resolved external tools test failures on Rocky 9. |
|
I don't understand what this change has to do with Rocky 9 but it's non-controversial and the tests are passing. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Some tests were failing in external tools because they return an array of tools and assume that the first tool in the array is the one they want to validate/verify. The tests have been updated to retrieve the test subject tool by its id.
Which issue(s) this PR closes:
Closes #10271 API Tests Failing
Special notes for your reviewer:
Suggestions on how to test this: mvn test -Dtest=ExternalToolsIT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no
Additional documentation: none