IQSS/10559-2 Drop COMMIT_WITHIN which breaks autoSoftCommit by maxTime in solrconfig #10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Performance testing and subsequent investigation shows that using the commit_within parameter in the solrj calls was disabling the autoSoftCommit by maxTime set at 1 second in the solrconfig.xml, causing delays in newly indexed things being visible of up to 30 seconds. (It's not clear if this is new with the new solr version or not - there was some discussion in #10559 about latency, but nothing near the ~30 seconds we're seeing now.) Removing them appears to re-enable the autoSoftCommit. (FWIW: the commit_within parameter did not disable using autoSoftCommit with maxDocs instead.)
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: Doing a full reindex on a db that should take 30 seconds + and repeatedly checking to see when counts show in the interface is how this was detected. You should see changes every ~1 second/as fast as you can refresh. Nominally any other call to index should cause new results to appear within a few seconds (however long indexing takes plus the 1 second autoSoftCommit) and nothing near 30 seconds (which is our default autoCommit (hard) setting.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: