IQSS/5043 streaming and new exporters #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
QDR-953_streaming_exports Conflicts: src/main/java/edu/harvard/iq/dataverse/DataCitation.java
This was referenced Oct 15, 2018
pdurbin
reviewed
Oct 15, 2018
| @@ -209,17 +205,17 @@ public void exportFormat(Dataset dataset, String formatName) throws ExportExcept | |||
| if (releasedVersion == null) { | |||
| throw new IllegalStateException("No Released Version"); | |||
| } | |||
| JsonPrinter jsonPrinter = new JsonPrinter(settingsService); | |||
| final JsonObjectBuilder datasetAsJsonBuilder = jsonPrinter.jsonAsDatasetDto(releasedVersion); | |||
| final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(releasedVersion); | |||
There was a problem hiding this comment.
I'm wondering if no longer passing "settingsService" into the JsonPrinter constructor has led to #5185 about ":ExcludeEmailFromExport" no longer working.
|
@kcondon - Since this PR updates the citation.tsv file, I think the release notes should tell people to run the curl api command to reinstall it. Is there someplace you capture that? |
|
@qqmyers Yes, I've documented it in my release deployment doc which I use to both deploy in prod and to write upgrade instructions: Thanks for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist