Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 3439 zip upload checkbox disable unzip #5396

Closed

Conversation

rmo-cdsp
Copy link
Contributor

@rmo-cdsp rmo-cdsp commented Dec 12, 2018

Related Issues

Pull Request Checklist

What is done here:

  • Optional boolean value for the api "Add a File to a Dataset" to prevent unzip of zip files uploaded to a dataset
  • Checkbox available in the GUI (true by default) to prevent unzip of zip files uploaded to a dataset

What has to be done/I need:

  • Help/advices for the GUI part, because I'm not a designer ! :D
  • The text to display for the GUI checkbox label (and add it to the bundle files)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 17.678% when pulling 582ba17 on rmo-cdsp:3439-zip-upload-checkbox-disable-unzip into 881694b on IQSS:develop.

@djbrooke
Copy link
Contributor

Hey @rmo-cdsp! Preventing unzipping results in a lot of functionality being lost in Dataverse, and zip are not a good format for preservation. Double zipping to prevent unzipping is a workaround until #2249 is worked on, which will allow researchers to keep their file hierarchy.

We won't accept this PR into the develop branch, so I'm going to close this PR, but if there's code that you'd like to make available to the community for those that do want this feature, feel free to leave a note in the issue with a link to where users can find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants