Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5583 toggle email dataverse export #5655

Merged
merged 6 commits into from
Mar 20, 2019
Merged

Conversation

matthew-a-dunlap
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap commented Mar 15, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Mar 15, 2019

Coverage Status

Coverage increased (+0.3%) to 17.811% when pulling 83af6f5 on 5583-toggle-email-dataverse-export into 9439313 on develop.

return allowCors(response(req -> ok(
json(execCommand(new GetDataverseCommand(req, findDataverseOrDie(idtf))),
false,
settingsService.isTrueForKey(SettingsServiceBean.Key.ExcludeEmailFromExport, false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthew-a-dunlap please update the docs on :ExcludeEmailFromExport. Thanks!

@matthew-a-dunlap
Copy link
Contributor Author

I've updated the docs and responded to some points discussed offline with @scolapasta . Let me know if there is anything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants