5584 Filtering of Files on Dataset Page, Search using Solr #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(facets are not working yet) (#5584)
- added an indexed flag, for the published files removed from the current draft; - backward compatibility, if talking to a solr server with an older schema; - added check for solr being down - reverting back to searching in the db if it is. (#5584)
…le that's been removed from the current draft. (#5584)
…t to bundle [ref #5584]
…adata on dataset pg [ref #5584]
djbrooke
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
Per discussion with @mheppler, looking at the rendering rules in the fragment - specifically things like where it says "no files in the dataset" where it should really be saying "your search found nothing".
|
…n the dataset" and "search found no files" situation, and paging. (#5584)
|
Updated the "no results found" msg for the files table on the dataset pg and moved it to the bundle. Render logic added by @landreev looks good.
|
scolapasta
reviewed
May 21, 2019
| // This 2nd search() is for populating the facets: -- L.A. | ||
| // TODO: ... | ||
| // This 2nd search() is for populating the "type" ("dataverse", "dataset", "file") facets: -- L.A. | ||
| // (why exactly do we need it, again?) |
There was a problem hiding this comment.
I believe it's to get the counts (since it shows those counts even if that facet is not checked, ie those types are not returned by the search).
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA
May 21, 2019
scolapasta
approved these changes
May 21, 2019
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA
to Done 🚀
May 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist