Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove log4j 1.x (EOL) #6519

Merged
merged 5 commits into from
Feb 27, 2020
Merged

remove log4j 1.x (EOL) #6519

merged 5 commits into from
Feb 27, 2020

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 14, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 19.464% when pulling 7c8df04 on remove-log4j1 into 74b499a on develop.

@kcondon kcondon self-assigned this Feb 18, 2020
@kcondon
Copy link
Contributor

kcondon commented Feb 18, 2020

@pdurbin @scolapasta Build fails:
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal on project dataverse: Could not resolve dependencies for project edu.harvard.iq:dataverse:war:4.18.1: Could not transfer artifact log4j:log4j:jar:1.2.15 from/to central-repo (http://repo1.maven.org/maven2): Failed to transfer file: http://repo1.maven.org/maven2/log4j/log4j/1.2.15/log4j-1.2.15.jar. Return code is: 501 , ReasonPhrase:HTTPS Required. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[JENKINS] Archiving /var/lib/jenkins/workspace/Dataverse_rfi/pom.xml to edu.harvard.iq/dataverse/4.18.1/dataverse-4.18.1.pom
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
channel stopped

@kcondon
Copy link
Contributor

kcondon commented Feb 18, 2020

@pdurbin @scolapasta @landreev Spoke with Leonid, look like maven repo now requires https: https://blog.sonatype.com/central-repository-moving-to-https

Will fix it.

Maven repo now requires https, updated relevant urls.
Missed a couple http
@kcondon
Copy link
Contributor

kcondon commented Feb 18, 2020

@pdurbin @scolapasta Ok, I've updated all http to https and now it builds but this needs to be refreshed from develop since it is still trying to build 4.18.1

@kcondon kcondon removed their assignment Feb 18, 2020
@djbrooke djbrooke moved this from IQSS Team Dev 💻 to IQSS Sprint 2/5 - 2/26 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 18, 2020
@pdurbin pdurbin self-assigned this Feb 24, 2020
@pdurbin pdurbin moved this from IQSS Sprint 2/5 - 2/26 to IQSS Team Dev 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 24, 2020
@pdurbin
Copy link
Member Author

pdurbin commented Feb 24, 2020

In 52a4f82 I merged the latest from develop.

@pdurbin pdurbin moved this from IQSS Team Dev 💻 to Code Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 24, 2020
@pdurbin pdurbin removed their assignment Feb 24, 2020
@pdurbin
Copy link
Member Author

pdurbin commented Feb 24, 2020

@kcondon I see that in b9ac210 you changed the DataONE repo to HTTPS but I'm seeing an error at https://travis-ci.org/IQSS/dataverse/builds/654612183

[ERROR] Failed to execute goal on project dataverse: Could not resolve dependencies for project edu.harvard.iq:dataverse:war:4.19: Failed to collect dependencies at edu.ucsb.nceas:ezid:jar:1.0.0: Failed to read artifact descriptor for edu.ucsb.nceas:ezid:jar:1.0.0: Could not transfer artifact edu.ucsb.nceas:ezid:pom:1.0.0 from/to dataone.org (https://maven.dataone.org): Transfer failed for https://maven.dataone.org/edu/ucsb/nceas/ezid/1.0.0/ezid-1.0.0.pom: Certificate for <maven.dataone.org> doesn't match any of the subject alternative names: [jenkins-ucsb-1.dataone.org, slack.dataone.org, slack.lternet.edu, slack.nceas.ucsb.edu] -> [Help 1]

Screen Shot 2020-02-24 at 4 46 07 PM

I'd be happy to switch it back to plain HTTP if you want. Or you can. Please advise.

Also, I'm wondering where we should report this to DataONE. I see a related issue at DataONEorg/DataONE_Operations#9 which I found from https://dataone-operations.readthedocs.io/en/latest/DEV/continuousbuild.html

@pdurbin
Copy link
Member Author

pdurbin commented Feb 25, 2020

@kcondon nevermind. I reached out to @mbjones and he worked with the DataONE team to get their cert working (thanks!! 🎉 ). I just clicked "Restart" in Travis for this pull request and it switched from red to green, so we should be good.

Screen Shot 2020-02-25 at 9 34 19 AM

Screen Shot 2020-02-25 at 9 34 26 AM

Screen Shot 2020-02-25 at 9 47 05 AM

@pdurbin
Copy link
Member Author

pdurbin commented Feb 27, 2020

@kcondon in 7c8df04 I just merged the latest from develop.

@kcondon kcondon merged commit 2010721 into develop Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants