-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5716 edit file api perms #6847
5716 edit file api perms #6847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm impressed that you added that whole dedicated test to api/DatasetsIT, just to get a BAD_REQUEST in the end... I mean, it makes sense, but still.
@landreev I thought there was going to be more to it than that, but after writing the test I realized that the update version has never been used to add files so I left it at that. |
Makes sense. And it's still a useful test. |
added note about adding files via create dataset api
What this PR does / why we need it:
This PR restricts the use of the import dataset and create dataset (with files) to accounts with superuser permissions. This is needed to strictly limit the instances in which file metadata/datafile records are created in the absence of a physical file.
Which issue(s) this PR closes:
Closes #5716
Special notes for your reviewer:
Suggestions on how to test this:
verify that a non-super user may still use the create dataset api as long as files are not included.
Does this PR introduce a user interface change?:
No
Is there a release notes update needed for this change?:
Additional documentation: