Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed f:viewParam to o:Param for editMode #6851

Merged
merged 1 commit into from
Apr 23, 2020
Merged

changed f:viewParam to o:Param for editMode #6851

merged 1 commit into from
Apr 23, 2020

Conversation

scolapasta
Copy link
Contributor

@scolapasta scolapasta commented Apr 22, 2020 •
edited

What this PR does / why we need it:
Fixes one last f:viewParam to o:viewParam
Which issue(s) this PR closes:

Closes #6230

Special notes for your reviewer:
This was one more case where the editMode would change with an ajax call.

Suggestions on how to test this:
test the editdatafiles page, specifically editing metadata, then editing a tag within that page

Does this PR introduce a user interface change?:
no

Is there a release notes update needed for this change?:
no

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.629% when pulling 320d5d5 on 6230-gf-upgrade-endgame into 27ed5dd on develop.

@pdurbin pdurbin self-assigned this Apr 22, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Apr 22, 2020
pdurbin
pdurbin approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love one character fixes. This falls in the same pattern as the others. Looks good.

@pdurbin pdurbin removed their assignment Apr 22, 2020
@kcondon kcondon self-assigned this Apr 23, 2020
@kcondon kcondon merged commit 4a0da70 into develop Apr 23, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Apr 23, 2020
@kcondon kcondon deleted the 6230-gf-upgrade-endgame branch April 23, 2020 16:10
@djbrooke djbrooke added this to the Dataverse 5 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

Assignees

@kcondon kcondon

Labels
None yet
Projects
No open projects
IQSS/dataverse (TO BE RETIRED / DELET...
Done 🚀
Milestone
Dataverse 5
Development

Successfully merging this pull request may close these issues.

Upgrade from Glassfish 4.1
5 participants
@scolapasta @coveralls @pdurbin @kcondon @djbrooke