Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6753 Fixed dataset metadata table width #6912

Merged
merged 1 commit into from
May 14, 2020

Conversation

mheppler
Copy link
Contributor

What this PR does / why we need it:

Fixes inconsistent dataset metadata table width, which resulted in inconsistent label column widths.

Which issue(s) this PR closes:

Closes #6753 Geospatial Metadata fields not properly indented compared to other fields

Special notes for your reviewer:

Small CSS change in the stylesheet to fix width and resolve minor vertical align inconsistency.

Suggestions on how to test this:

Add a whole bunch of metadata to a bunch of different blocks and see how it looks on the dataset pg.

Does this PR introduce a user interface change?:

No, it cleans up current UI.

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@mheppler mheppler changed the title Fixed dataset metadata table width [ref #6753] 6753 Fixed dataset metadata table width May 13, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ May 13, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.614% when pulling bec9e3f on 6753-dataset-metadata-label-col-widths into 5fcad4b on develop.

@kcondon kcondon self-assigned this May 14, 2020
@kcondon kcondon merged commit 20cbb88 into develop May 14, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 May 14, 2020
@kcondon kcondon deleted the 6753-dataset-metadata-label-col-widths branch May 14, 2020 15:17
@djbrooke djbrooke added this to the Dataverse 5 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Geospatial Metadata fields not properly indented compared to other fields
5 participants