Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new button styles to Style Guide, Patterns pg [ref #6940] #7007

Merged
merged 2 commits into from Jul 1, 2020

Conversation

mheppler
Copy link
Contributor

What this PR does / why we need it:

Added new button styles with code example to Style Guide, Patterns pg.

Which issue(s) this PR closes:

Closes #6940 Style Guide - Review and update UI references for new btn's on dataset and file pgs

Special notes for your reviewer:

N/A

Suggestions on how to test this:

Build guides in Sphinx. See screenshot in issue.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@coveralls
Copy link

coveralls commented Jun 22, 2020

Coverage Status

Coverage remained the same at 19.557% when pulling d15feb7 on 6940-style-guide-new-buttons into b97185a on develop.

@TaniaSchlatter
Copy link
Member

TaniaSchlatter commented Jun 23, 2020

I'd like the guides to include an example of the "Access" button on a file page, and describe:

  • the visual hierarchy of more important buttons being stronger color
  • grouping Download and Explore options

I'd like the description of the icon only buttons to include that there can be up to 3 of these buttons for a file, and that if there are more than 3, one of the three should be a "kebab" icon with a dropdown.

@mheppler mheppler moved this from Code Review 🦁 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jun 23, 2020
@djbrooke djbrooke removed their assignment Jun 24, 2020
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 24, 2020
@mheppler
Copy link
Contributor Author

Updates requested by @TaniaSchlatter above delivered. Built to test server.

Screen Shot 2020-06-25 at 2 01 58 PM

@mheppler mheppler moved this from IQSS Team - In Progress 💻 to Code Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jun 25, 2020
@mheppler mheppler assigned TaniaSchlatter and unassigned mheppler Jun 25, 2020
@TaniaSchlatter
Copy link
Member

Looks good. I think this is all set.

Copy link
Member

@TaniaSchlatter TaniaSchlatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jun 25, 2020
@djbrooke djbrooke removed their assignment Jun 26, 2020
@kcondon kcondon self-assigned this Jul 1, 2020
@kcondon kcondon merged commit 6bc6795 into develop Jul 1, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 1, 2020
@kcondon kcondon deleted the 6940-style-guide-new-buttons branch July 1, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Style Guide - Review and update UI references for new btn's on dataset and file pgs
5 participants