The sample ejb-jar.xml file had a bad version number that would preve… #7181
Conversation
…nt deployment of the application if the ejb-jar file was used to modify the saved searchers timer schedule. I updated the timer.rst file to document a procedure for inserting an edited ejb-jar.xml file into a war, rather than doing a full build of the application
djbrooke
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
|
||
| * The provided parameters in the sample file are <minute>, <hour>, and <dayOfWeek>; additional parameters are available | ||
|
|
||
| * For a complete reference for calendar expressions that can be used to schedule Timer services see: https://docs.oracle.com/javaee/7/tutorial/ejb-basicexamples004.htm | ||
|
|
||
| * Build and deploy the application | ||
|
|
||
| * Alternatively, you can insert an ejb-jar.xml file into a provided dataverse war file without building the application. | ||
|
|
||
| * Check if there is already an ejb-jar.xml file in the war file (as I'm writing, the dataverse war file is named dataverse-4.20.war) |
There was a problem hiding this comment.
Since this will be for the Dataverse 5 release, we should change this to that - I think you can also jsut say e.g. instead of "as I'm writing"
There was a problem hiding this comment.
like 'Check if there is already an ejb-jar.xml file in the war file, e.g dataverse-5.war' and same wherever referenced in the commands?
|
Confirmed the instructions work, thanks Bob. Passing over to Danny/Mike for doc formatting clean up. |
djbrooke
moved this from QA 🔎✅
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
One thing I noticed when I looked back at what Kevin showed me, is that aside from the enlarged text, which I have no idea where that comes from, even after reading the basic sphinx documentation, there also a logical formatting error, which I could fix, but since you guys have it now, maybe you could take care of. The last 3 lines of my instructions, eg |
…t sub-bullet points [ref #7175]
…nt deployment of the application if the ejb-jar file was used to modify the saved searchers timer schedule.
I updated the timer.rst file to document a procedure for inserting an edited ejb-jar.xml file into a war, rather than doing a full build of the application
What this PR does / why we need it:The sample file cannot be used with the wrong version number
Which issue(s) this PR closes:Bad version number in sample ejb-jar.xml; document procedure for updating the war file to include the ejb-jar.xml outside of a build environment
Closes #7175
Special notes for your reviewer:
Suggestions on how to test this: You can test the procedure documented at the end of the timer.rst file. The description of this procedure starts with "Alternatively, you can insert an ejb-jar.xml ..."
Does this PR introduce a user interface change? If mockups are available, please link/include them here:no
Is there a release notes update needed for this change?:no
Additional documentation: