file tags searchable from advanced search and dataset page #7194 #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Looks good; I edited the PR conversation to reflect that this does not close #7194, as that has spawned into a new discussion. But this clearly adds value for the first part, so moving it to QA.
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Nov 12, 2020
|
@pdurbin Would you refresh this from develop? |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
File tags are absent from the Advanced Search page. This pull request adds it.
When you type file tags into the search box for the file listing on the dataset page, you don't get hits on the files with those tags. (Only file name and file description are searched.) This pull request fixes this.
Which issue(s) this PR closes:
None. (This PR adds part of what is #7194; the 2nd part has expanded into a broader conversation, so we'll leave the issue open for that)
Special notes for your reviewer:
I followed the same pattern as other search fields. I didn't re-write the search code.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Screenshot of "File Tags" from the Advanced Search page:
Screenshot of searching for a tag called "Foo Bar" on the file listing on the dataset page:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
None.