Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7417 - Update to Payara 5.2020.6 #7419

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

poikilotherm
Copy link
Contributor

What this PR does / why we need it:
Stability, security, bug fixes. Good thing, aren't they? Grateful for having them now after the dark days of Glassfish 4.1

Which issue(s) this PR closes:

Closes #7417

Special notes for your reviewer:
Dunno?

Suggestions on how to test this:
Follow the instructions to update. They take extreme precautions that might not be necessary, but better safe than sorry.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
🔋 included.

Additional documentation:
Nada.

@poikilotherm poikilotherm added Feature: Installation Guide Feature: Admin Guide User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh labels Nov 17, 2020
@poikilotherm poikilotherm added this to the 5.3 milestone Nov 17, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few more places where we should update Payara. Please see the comments I left.

@coveralls
Copy link

coveralls commented Nov 17, 2020

Coverage Status

Coverage remained the same at 19.48% when pulling 40b0b4c on poikilotherm:7417-payara-5.2020.6 into 9cce13d on IQSS:develop.

@djbrooke djbrooke removed this from the 5.3 milestone Nov 17, 2020
@djbrooke djbrooke moved this from Review 🦁 to Community Dev 💻❤️ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 17, 2020
@poikilotherm poikilotherm moved this from Community Dev 💻❤️ to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 18, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I think we've identified all the instances of .2 that need to be changed to .6 but I added an additional question about upgrade docs. Basically, are we ok with linking to the official Payara docs or would it be better to write our own steps?

doc/release-notes/7417-payara-5.2020.6.md Outdated Show resolved Hide resolved
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@pdurbin
Copy link
Member

pdurbin commented Nov 18, 2020

Basically, are we ok with linking to the official Payara docs or would it be better to write our own steps?

The consensus from Slack with me @landreev @kcondon and @djbrooke was that we're ok linking to the Payara docs so I'll go ahead and move this to QA.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Nov 18, 2020
@kcondon
Copy link
Contributor

kcondon commented Nov 19, 2020

@poikilotherm @pdurbin
Tested fresh install, works fine.

Tested upgrade, used backup/restore domain method. Needs an additional step for Dataverse to run: copy postgres driver from old payara to new payara glassfish/lib dir. Should this go in release notes or will it be handled by the downstream pr?

Putting back into Review for comment.

@poikilotherm
Copy link
Contributor Author

poikilotherm commented Nov 19, 2020

Well as the next PR about moving the Postgres driver into the WAR is already done #7420 and just waiting for review, I vote for not including a hint about that.

@kcondon
Copy link
Contributor

kcondon commented Nov 19, 2020

So you would not confirm the upgrade worked before deploying the new war? I suppose it doesn't matter but wanted to ask. Game on!

@kcondon kcondon merged commit 40cda0e into IQSS:develop Nov 19, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to Done 🚀 Nov 19, 2020
@poikilotherm poikilotherm deleted the 7417-payara-5.2020.6 branch November 19, 2020 16:15
@djbrooke djbrooke added this to the 5.3 milestone Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Admin Guide Feature: Installation Guide User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade Payara Application Server to 5.2020.6
6 participants