improve messaging for ingest failures, file upload #8096 #8271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
moved this from Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
moved this from IQSS Team - In Progress 💻
to Up Next 🛎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
moved this from Up Next 🛎
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
force-pushed
the
8096-8205-ingest-messaging
branch
from
a3d99bd
to
94c834d
Compare
Note that when you upload a mix of files that go through ingest and some succeed and some fail, the failure message is sent.
- Only list files that failed ingest. - Remove "(Error)" from next to file name. - Change "file(s)" to "files". - Remove "Dataverse" to avoid having to say "Dataverse Software".
pdurbin
force-pushed
the
8096-8205-ingest-messaging
branch
from
55d5ac0
to
3b1e71b
Compare
pdurbin
changed the title
pdurbin
moved this from IQSS Team - In Progress 💻
to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
moved this from Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
We decided the "dataset management" page has more context. Previously, the standard guides server base URL and "latest" was hard coded.
- rewrite sentence for .tab - link to "the guides" not "see the guides" - only have the last link (to "the guides")
pdurbin
moved this from IQSS Team - In Progress 💻
to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
@TaniaSchlatter @jggautier and I met this morning and in 5d9a0dd I just made the changes we talked about. I also updated the screenshots above. This pull request is ready for review so I moved it over. |
|
Thanks for the screenshots @pdurbin. All looks good, and I wonder if we can have the text that appears in the top of page in the info alert message on the edit page can appear as text in the File upload page instead. If we are not providing new or contextual info in the top of page message, there is not a reason to have it appear as an info alert. |
pdurbin
moved this from Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
@TaniaSchlatter and I just talked through moving text from the blue info alert to inline text. Implemented in a2be27b and I updated the screenshot above. I'm moving this back into review. |
pdurbin
moved this from IQSS Team - In Progress 💻
to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
Looks good! Thanks @pdurbin. |
sekmiller
approved these changes
Jan 5, 2022
sekmiller
moved this from Review 🦁
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jan 5, 2022
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We are trying to soften the messaging around ingest to prevent support tickets. This pull request also improves the messaging on file upload, especially with regard to limits and providing links to information in the guides about tabular ingest.
Which issue(s) this PR closes:
Special notes for your reviewer:
None.
Suggestions on how to test this:
See release note.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Add files on create
Add files on edit
Improved "failed ingest" messaging (dataset page)
Tooltip behavior (greyed out, dark on hover, popup on click)
Improved "failed ingest" messaging (file page)
Email: success only
Email: failure only
Email: mix of failure and success (as of 55d5ac0 looks same as "failure only")
In-app notification: success
In-app notification: failure only or mix of failure and success
Add files on edit (dual mode and public only install)
This screenshot is last but relates to the "add files on edit" screenshot above. As part of this pull request, the "Multiple file upload/download methods are available for this dataset" message has been moved to under the "Files" tab (and is now plain text rather than being in a blue info box). The yellow info message "Files are stored on a publicly accessible storage server. – " has not been changed.
Is there a release notes update needed for this change?:
Included.
Additional documentation:
Included.