Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/8422 default to allow dataset level choice of metadatalanguage #8440

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 18, 2022

What this PR does / why we need it: Per the issue, the recent enhancement to add a choice of metadata language restricted that choice to collections and, if no collection-level choice was made, the global default option (the machine locale/language) was chosen. This PR changes the default behavior such that, if the metadatalanguage isn't chosen in an ancestor collection, the user is allowed/forced (because there is no 'none' option) to chose a language at dataset creation. (This is only if the metadata language setting is configured in the first place.) Thus, this allows a use case where a collection/repository manager can let users decide which language to use and have collections that include datasets using different metadata languages.

Which issue(s) this PR closes:

Closes #8422

Special notes for your reviewer:

Suggestions on how to test this: Configure metadatalanguages, verify that the dataverse/edit/general entry for metadata language includes the new value 'Chosen at Dataset Creation' and that choosing that on the root or child dataverse triggers a change in the dataset creation page to allow a user to chose the metadata language (versus showing the predefined choice from the collection level) -see image below.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
The change in the dataset page, only if metadatalanguage is enabled and only in collections where a choice hasn't been made is for the metadata language to be a live input:
image

Is there a release notes update needed for this change?:

Additional documentation: Change in default behavior note in the config docs

move asterix message to top of metadata table
handle using template during dataset creation
docs re: the change to default
stype tweaks to add instructions and style the selection box the same as
others, e.g. the template selection
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Mar 7, 2022
@landreev
Copy link
Contributor

landreev commented Mar 7, 2022

(I have approved the PR, but please take a look at the failed integration test. It looked like it was something outside the PR that killed ansible, but please double-check).

…_allow_dataset_level_choice_of_metadatalanguage
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 18.854% when pulling 622e83e on GlobalDataverseCommunityConsortium:IQSS/8422-default_to_allow_dataset_level_choice_of_metadatalanguage into 75414ea on IQSS:develop.

@landreev landreev removed their assignment Mar 7, 2022
@kcondon kcondon self-assigned this Mar 7, 2022
@kcondon kcondon merged commit a629d18 into IQSS:develop Mar 7, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Mar 7, 2022
@pdurbin pdurbin added this to the 5.10 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Metadata Languages should be able to be disabled per collection, and set at the dataset level
5 participants