Fix broken links under "Best Practices" (nav bar) in guides, sync up with dataverse.org #8486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
I think @TaniaSchlatter and Dwayne are working on this. I'd defer to them. |
pdurbin
changed the title
|
@TaniaSchlatter and I met to discuss the pull request and decided to sync up the "Best Practices" dropdown in the guides with the one on dataverse.org, which I did in 54228c1. That is, dataverse.org has these 5 links:
And now as of this pull request, the guides will have the same 5 links:
|
TaniaSchlatter
approved these changes
Mar 15, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Mar 15, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
All the links under "Best Practices" are broken:
Which issue(s) this PR closes:
Closes IQSS/dataverse.harvard.edu#24
Special notes for your reviewer:
The impression I get from #9216 is that we're trying to avoid Harvard specific content on dataverse.org so I removed the link to "Harvard Dataverse Policies". To add it back in we can just revert 11d943e
Suggestions on how to test this:
Make sure the links work.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.