Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8456 upgrade primefaces #8652

Merged
merged 11 commits into from
Apr 29, 2022
Merged

8456 upgrade primefaces #8652

merged 11 commits into from
Apr 29, 2022

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Apr 25, 2022

What this PR does / why we need it: upgrades Primefaces to version 11 for latest features, security upgrades, etc.

Which issue(s) this PR closes:

Closes #8456 Upgrade to Primefaces 11

Special notes for your reviewer: Basically went through the migration guide to see what may apply to Dataverse (just a couple of style sheet edits) https://primefaces.github.io/primefaces/11_0_0/#/../migrationguide/11_0_0

Suggestions on how to test this: No functional changes. Just a smoke test on the app.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Popup dialogs will now automatically resize when the window for the app is resized.

What the popup looks like before resizing the browser:
Screen Shot 2022-04-25 at 2 16 32 PM

With auto resizing (New default behavior with Primefaces 11):

Screen Shot 2022-04-25 at 2 16 47 PM

Without Auto resizing (Default Behavior with Primefaces 10):

Screen Shot 2022-04-25 at 3 53 50 PM

Is there a release notes update needed for this change?: doc/release-notes/8456-upgrade-primefaces.md

Additional documentation: None

@sekmiller sekmiller moved this from Next Sprint 🏃 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 25, 2022
@sekmiller sekmiller moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 25, 2022
@sekmiller sekmiller self-assigned this Apr 25, 2022
@scolapasta scolapasta self-assigned this Apr 25, 2022
@coveralls
Copy link

coveralls commented Apr 25, 2022

Coverage Status

Coverage remained the same at 18.969% when pulling 74dc796 on 8456-upgrade-primefaces into e713194 on develop.

@sekmiller sekmiller removed their assignment Apr 25, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Apr 26, 2022
@kcondon kcondon assigned kcondon and unassigned scolapasta Apr 27, 2022
@kcondon
Copy link
Contributor

kcondon commented Apr 27, 2022

Issues:
[x] 1. Edit terms shows restricted file red info banner when no restricted files present, prevents saving. [update] was a weird caching issue. Gone.
[x] 2. Seeing an exception when viewing dv/collection group page:StandardWrapperValve[Faces Servlet]: Servlet.service() for servlet Faces Servlet threw exception
javax.faces.FacesException: Unable to automatically determine the lazy attribute. Either define the lazy attribute on the component or make sure the value attribute doesn't resolve to null. clientId: manageGroupsForm:groupMembers
[x] 3. Exception when creating a copy of template on template listing page, complains about isValid and UI shows template created at null:
Screen Shot 2022-04-27 at 2 00 31 PM
isValiderr.txt
Note if you refresh the page the above copy disappears. Also, if you view the template it only shows terms not metadata portion.

  1. Deleting guestbook does not automatically disappear from page list, needs page refresh unlike v5.10.1

@sekmiller sekmiller self-assigned this Apr 28, 2022
@kcondon kcondon merged commit 6b1b0cb into develop Apr 29, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Apr 29, 2022
@kcondon kcondon deleted the 8456-upgrade-primefaces branch April 29, 2022 17:21
@pdurbin pdurbin added this to the 5.11 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade to Primefaces 11
5 participants