Update dataverse.xhtml to add "read more/read less" buttons for dataverse descriptions

[ant-reyes]

Added contentTruncateForDataverse() to allow dataverse descriptions to have "read more/read less" buttons.

What this PR does / why we need it: Our organization has a long description for our dataverse, which takes up too much space on the page. We needed a way to collapse the description. I reused the contentTruncate() function from dv_rebind_bootstrap_ui.js and added it to dataverse.xhtml scripts as contentTruncateForDataverse() to add this functionality.

Which issue(s) this PR closes: N/A

• Closes Dataverse - Description text truncated #1249
• Closes Truncate Dataverse Description Text #9265

Special notes for your reviewer: N/A

Suggestions on how to test this: N/A

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Read More:

Read Less:

Is there a release notes update needed for this change?:

Yes, included.

Additional documentation: N/A

[qqmyers]

So this is copying a javascript method used for datasets to apply it to dataverse/collection descriptions? Is it possible to reuse the function, e.g. by making the selector a parameter? (Rather than duplicating the method with a minor change?) Other than the target element, are there other changes?

[pdurbin]

Closes # N/A

@ar062800 thanks for the pull request! I think you can safely update the description of the PR to say that it closes this issue:

• Dataverse - Description text truncated #1249

By the way, the truncation of dataset descriptions was added in this PR:

• 6685 truncate methods - dataset pg summary block description #7644

[pdurbin]

@ar062800 Happy New Year! I'm just checking in. Please read through the feedback from me and @qqmyers above and let us know your thoughts. Thanks! If it's easier, you're welcome to ping me at https://chat.dataverse.org

Another thought that come to mind:

• We should add a release note snippet explaining the feature. We can help you with this but the process is documented here (we should probably find a better place for it): https://guides.dataverse.org/en/5.12.1/developers/making-releases.html#write-release-notes

[pdurbin]

@ar062800 and I had a Zoom call. We want to remove the hard-coded English values.

We added a release note.

He tried to re-use the function in the rebind file. We can defer this to later (maybe @qqmyers or I can give it a shot before moving this to QA).

[pdurbin]

In the original, the English (or non-English) button text is passed in like this:

function contentTruncate(truncSelector, truncMoreBtn, truncMoreTip, truncLessBtn, truncLessTip){

Can you please do something similar and remove the hard-coded English strings, below?

[qqmyers]

FWIW : #9265 is one way to reuse the old method. I've tested it briefly. If it works for everyone - if there are other changes in this PR we could try to figure out how to merge. If not, it may still show how to avoid hardcoding the text.

[mreekie]

Prio meeting with Stefano.

• Moved from Community Backlog to ordered backlog

[pdurbin]

@ar062800 hi! I'm just checking in. Please let me know if you'd like to do another quick call. Also, you may want to check out the PR from Jim above for inspiration. Like we talked about, the main thing is to avoid having hard coded English strings (so that Dataverse can be translated to French, etc.) Thanks!

[pdurbin]

@ar062800 after dc9a297 this PR is looking much smaller and seems to reuse code more! Are you ready for more review?

[pdurbin]

I've been chatting with @ar062800 in Matrix. I'm ready to approve this PR (send it to "Ready for QA"). It's in the sprint already so I think it's just a matter of @mreekie adding it to the board.

[pdurbin]

I haven't run the code myself but I've been talking to @ar062800 and @qqmyers about it. The changes look good. I think it's ready for QA. Approved.

[kcondon]

@pdurbin Need refresh from develop due to flyway error.

[pdurbin]

@kcondon done! Sorry for not catching that earlier! 😅 😬

[sergejzr]

Good day! The functionality is good, however we would like to keep it long for most of our dataverses. Is it planned to have it adjustable per dataverse (I didn't find such option in the conversations so far)? Otherwise, we will have to hack around ourselves.

[pdurbin]

@sergejzr no, this isn't planned but please feel free to create an issue. Thanks.