#9498 - fixing issue while searching for TermUri field that is a compound field #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luddaniel - thanks for the fix. I think this is already in #9402 - there were several places where trying to use the external vocab mechanism on a single child did not work. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will allow a compound field that is set as
"term-uri-field"incvoc-conf.jsonfile to be indexed in SOLR with all values ofexternalvocabularyvalue.valuetable.Without this PR, only when
"field-name"equals"term-uri-field", values cached from a skosmos term will be indexed properly.Which issue(s) this PR closes:
Closes #9498
Suggestions on how to test this:
Make sure that you can search Term in different languages using non compound or compound field with skosmos external vocab support (CVOC).
Example with non compound field :
Example with compound field :
Is there a release notes update needed for this change?:
Why not
Additional documentation:
related to commit 552a34a
Also, I have no idea if the change is needed is another function like json exporter.